magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.58k stars 9.32k forks source link

Lighthouse Accessibility failure #39054

Open JustinHermanM opened 3 months ago

JustinHermanM commented 3 months ago

Preconditions and environment

Steps to reproduce

Using Chrome with Lighthouse extension installed. Inspect and select Lighthouse Mode = Navigation (default) Device = Desktop Categories = Accessibility Analyze page load

Expected result

Pass with Accessibility score of 100

Actual result

Accessibility score of 95 Elements with an ARIA [role] that require children to contain a specific [role] are missing some or all of those required children. div.section-items.nav-sections-items.mage-tabs-disabled div#store.menu.section-item-content.nav-sections-item-content

Additional information

The parent -

I believe the child should have the role="tab" to pass Accessibility

Release note

No response

Triage and priority

m2-assistant[bot] commented 3 months ago

Hi @JustinHermanM. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 3 months ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 3 months ago

Hi @JustinHermanM,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

Screenshot 2024-08-20 at 12 01 49

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 3 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12783 is successfully created for this GitHub issue.

m2-assistant[bot] commented 3 months ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

hostep commented 2 months ago

@engcom-Bravo: can I ask you to increase the priority here? Because here in Europe a law will start applying from June 2025 onwards to force websites to adhere to accessibility rules. And since Magento has only one big release scheduled before that date (version 2.4.8, in April 2025), it would be good if we can get this fixed in 2.4.8 if possible.

Serfe-com commented 2 months ago

@hostep you can review the fix for this issue on !39164 where we got this into 100% in accessibility on Lighthouse. You can use that MR as a patch until Magento team merges it into the core.