magento / pwa-studio

đź› Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 683 forks source link

instructions to add a custom component to the header component are unclear #2704

Open acandael opened 4 years ago

acandael commented 4 years ago

I'm going through the tutorial 'Manage component and application state' under 'PWA studio fundamentals'.

Currently I'm stuck a the section 'Add component to the storefront'. The instructions are not clear to me:

"Add this button to your application’s Header component using steps similar to the steps described in the Modify the site footer tutorial."

But at this point in the tutorial there is no Header component. So should I use the same steps from the footer tutorial to create the Header component? If that is the case, this won't work as the header component has not the same dependencies as the footer component.

I think this section would be improved, if it explains step by step what needs to happen, instead of refering to the footer tutorial.

m2-assistant[bot] commented 4 years ago

Hi @acandael. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


acandael commented 4 years ago

@magento I am working on this

m2-assistant[bot] commented 4 years ago

Hi @acandael! :wave: Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

acandael commented 4 years ago

@magento add to contributors team

m2-assistant[bot] commented 4 years ago

Hi @acandael! :wave: Thank you for joining. Please accept team invitation :point_right: here :point_left: and add your comment one more time.

acandael commented 4 years ago

@magento add to contributors team

levtronix commented 2 years ago

@magento add to contributors team

m2-assistant[bot] commented 2 years ago

Hi @levtronix! :wave: Thank you for joining. Please accept team invitation :point_right: here :point_left: and add your comment one more time.