magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 683 forks source link

[feature]: Change the ProductDetail query from url_key to id #2835

Open lewisvoncken opened 4 years ago

lewisvoncken commented 4 years ago

Describe the solution you'd like You do a Product search based on url_key but the url_key is already resolved and returns the actual product id so you can just retrieve the data for that specific product and not query on the url_key. This is also better for performance.

see for more info https://github.com/magento/pwa-studio/blob/develop/packages/venia-ui/lib/RootComponents/Product/product.js#L26

When the url_key is not searchable and you use the url_key to get the info of the current product, all the product detail pages will be the same

Please let us know what packages this feature is in regards to:

m2-assistant[bot] commented 4 years ago

Hi @lewisvoncken. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this