magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 684 forks source link

[bug]: PWA multiple wishlist: storefront still showing create whishlist button when reach max number of allowed wishlists configured in magento #3632

Closed mywebcom closed 2 years ago

mywebcom commented 2 years ago

Describe the bug

When customer creates certain number of wishlist and reach the max number of allowed wishlist configured in magento admin.

https://docs.magento.com/user-guide/marketing/wishlist-configuration.html

create a list button is still showing on the storefront. logically, the button should be removed once the max number is reached.

To reproduce

Steps to reproduce the behavior:

  1. Go to PWA storefront
  2. Login as a customer
  3. Go to Wishlist
  4. Add 5 wishlist lists as configured in Magento admin
  5. See the "Create a list" button still showing

Expected behavior

"Create a list button" should be hidden.

Screenshots

 

Test Plan 

 - Verify single wishlist for commerce edition

 - Verify single wishlist for Community edition

 - Verify Multiple wishlist for 2 and 5 wishlist as config and make sure Venia UI respects the backend configs.

 - Verify in Chrome , FF, Safari and Mobile device

 - Update Multiple wishlist mock data cypress test to include this fix test coverage

 

m2-assistant[bot] commented 2 years ago

Hi @mywebcom. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


supernova-at commented 2 years ago

@magento export issue to JIRA project PWA as Bug

github-jira-sync-bot commented 2 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/PWA-2479 is successfully created for this GitHub issue.