magicstx / magic-protocol

UI and contracts for the Magic protocol
https://docs.magic.fun
GNU General Public License v2.0
10 stars 10 forks source link

Duplicate pending swap IDs #12

Open whoabuddy opened 2 years ago

whoabuddy commented 2 years ago

After trying my first swap back and forth with my own supplier, I wanted to try something a bit tricker.

I initiated a swap with a supplier for their total value of BTC, then another with my own for a large portion of my balance. I wanted to see if I could do two swaps side by side with different suppliers, and noticed both transactions are duplicated when viewing my swaps.

Screenshot from 2022-07-26 12-02-16

The first swap is stuck pending and has a warning that the supplier may not be responsive:

Screenshot from 2022-07-26 12-04-01

The second one seems to be complete, probably just waiting on confirmations.

Screenshot from 2022-07-26 12-06-14

Edit: confirmed the 2nd one was successful, but still showing twice:

Screenshot from 2022-07-26 12-19-36

Swap IDs for reference:

dumbledope commented 2 years ago

Thank you for the report! This is a weird one - I'm not totally sure what the cause is yet. I'd assume it's related to how you made two in-progress swaps, although obviously that's perfectly valid usage. I'll have to try and reproduce.

whoabuddy commented 2 years ago

I think it may be something else, looking at the list again one of my original (single) swaps is duplicated as well:

Screenshot from 2022-07-29 08-53-12

Swap ID: 0x551f38b1fcfcd1b07e7e60c754eeb1d871964c7eee13b18e3d7833b633881613

If there's anything I can look up on my side let me know.