magicuidesign / magicui

UI Library for Design Engineers. Animated components and effects you can copy and paste into your apps. Free. Open Source.
https://magicui.design
MIT License
12.08k stars 484 forks source link

feat: update text reveal component #390

Open ZiJson opened 1 month ago

ZiJson commented 1 month ago

I have been using MagicUI for a while, and I love its clean design and fancy effects. However, when I use the Text Reveal component, it seems to be less flexible, so I couldn't help modifying it. I hope these changes help.

The major changes are:

https://github.com/user-attachments/assets/96e5145f-8a98-415e-bad7-0f2ff1c2b807

vercel[bot] commented 1 month ago

@ZiJson is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

itsarghyadas commented 2 weeks ago

@ZiJson Thank you for enhancing the component with support for child elements.

However, the other improvements:

Could you clarify the purpose of the additional props and the initial issue that led to these changes?

ZiJson commented 2 weeks ago

@itsarghyadas thanks for reply

I realized I initially made the component too complex, which made it hard to balance flexibility with ease of use. I've simplified my changes, keeping only the most useful parts:

The second and third changes are helpful for who want to place the revealing text at the left side, while custom content at the right side for example.

Any feedback or questions are welcome

itsarghyadas commented 2 weeks ago

Thanks for the reply. I will check it as soon as I get some time and will get back to you.