search

magit / forge

Work with Git forges from the comfort of Magit
GNU General Public License v3.0
1.3k stars 113 forks source link

Pressing RET (`magit-visit-thing`) on an URL in the `magit-process` buffer doesn't open URL #662

Closed dimsuz closed 4 months ago

dimsuz commented 4 months ago

When pushing to a PR on Github/Gitlab, the server often helpfully posts a link to a created/updated PR. My workflow is to always visit it and edit/review the PR.

remote: Resolving deltas: 100% (79/79), completed with 40 local objects.        
remote: 
remote: View merge request for my-branch-name:        
remote:   https://gitlab.com/group/project/-/merge_requests/994        
remote:

This is displayed in Magit's magit-process buffer and the link is correctly underlined and when mouse-clicked, external browser is opened, as desired.

But when pressing RET on this link the output I get is:

magit-visit-thing: There is no thing at point that could be visited

It would be nice if I wouldn't have to reach out for the mouse and for RET to work too.

Sorry I can't create a PR for this as I'm new to elisp and emacs/magit internals...

dimsuz commented 4 months ago

Ooops, sorry, wrong repository, I've meant to create this in magit repo, will move there.