search

magneticio / vamp-docker-images

Dockerfiles, compositions and related assets to setup Vamp with Docker
Apache License 2.0
21 stars 12 forks source link

Set development mode and activate all debug logs #38

Open brunomacf opened 7 years ago

brunomacf commented 7 years ago

At now all logs are disabled by default and this is no satisfactory for work with vamp-docker-images as a development environment for all vamp components. Consider to add a flag to sinalize development mode and activate all debug logs.

olafmol commented 7 years ago

@brunomacf is this specifically for the QuickStart package?

brunomacf commented 7 years ago

@olafmol I don't think so, since we can run clique- packages independently i think we should implement this strategy in each package. By the way, since quickstart is build upon other clique- modules it will inherit from it. What do you think? Did i understand you right?

olafmol commented 7 years ago

i think it makes a lot of sense to have a single flag to enable/disable logging for all components. 👍

brunomacf commented 7 years ago

Me too... but consider this: mesos logs for example are disabled in clique-zookeeper-marathon image and quickstart module inherits from it. So, to enable logging through a DEV flag we should script this up in clique-zookeeper-marathon and then this will be available in quickstart image. The same is true for elasticsearch logs which are disabled (i.e., only error logs) in clique-base image and all other images inherits from it.