search

mahaloz / decomp2dbg

A plugin to introduce interactive symbols into your debugger from your decompiler
BSD 2-Clause "Simplified" License
621 stars 39 forks source link

deprecation warning on plus with QKeySequence #57

Closed psifertex closed 1 year ago

psifertex commented 1 year ago

It looks like there's been a deprecation in PySide 6 and the BN plugin:

/Users/jordan/Library/Application Support/Binary Ninja/repositories/community/plugins/mahaloz_decomp2dbg/decompilers/d2d_binja/d2d_binja.py:135: PySideDeprecationWarningRemovedInQt6: 
The "+" operator is deprecated in Qt For Python 6.0 .
Please use "|" instead.
  UIAction.registerAction(configure_d2d_id, QKeySequence(Qt.CTRL + Qt.SHIFT + Qt.Key_D))

https://github.com/mahaloz/decomp2dbg/blob/main/decompilers/d2d_binja/d2d_binja.py#L135

Looks like there's more info at: https://doc.qt.io/qt-6/qkeysequence.html#details

but the obvious fix looks straight-forward. Happy to submit a PR, but didn't know if there was reason to keep that pattern around for some reason.

mahaloz commented 1 year ago

@psifertex fixed! I've bumped the latest version to 3.3.1 for this fix.