Closed unknown321 closed 10 months ago
I was unable to test symbol renaming while debugging, see log https://gist.github.com/unknown321/3fc213ee8592cc509e4f4d35dd071f8b. Symbols are renamed in ghidra interface, but plugin receives old names, so every symbol update in gdb is zero length.
Chose set as cache instead of dict because of key collisions - there were multiple "case" symbols with same name, but different addresses. Addresses as keys are not reliable - what if decompiler generates object and function at the same address?
I like it for now! Thanks for the PR
I was unable to test symbol renaming while debugging, see log https://gist.github.com/unknown321/3fc213ee8592cc509e4f4d35dd071f8b. Symbols are renamed in ghidra interface, but plugin receives old names, so every symbol update in gdb is zero length.
Chose set as cache instead of dict because of key collisions - there were multiple "case" symbols with same name, but different addresses. Addresses as keys are not reliable - what if decompiler generates object and function at the same address?