search

maidsafe-archive / safe-build-infrastructure

Houses internal build infrastructure
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Windows Rust Slave Fixes #17

Closed jacderida closed 5 years ago

jacderida commented 5 years ago

Hi Stephen,

This introduces another VM for building Rust code on Windows, the difference being that it removes the dependency on Jenkins, so you don't need a Jenkins master running to spin it up.

It also updates the README to say we need to be using the development version of Ansible for now.

You can run make travis_rust_slave-windows-2016-x86_64 to bring it up.

Cheers,

Chris

S-Coyle commented 5 years ago

@jacderida should this new VM be added to the VM table in the readme?

jacderida commented 5 years ago

Looks like it would make sense to update the readme's Windows Crust example to use the new travis_rust_slave-windows-2016-x86_64 machine - https://github.com/maidsafe/safe-build-infrastructure/blob/da360cd8345fe17e9bbebbf0bc9c812c1c7c04af/README.md#windows

I've updated the table with the new machine. I also removed any references to specific products, e.g. "Use for building SCL", as really these machines can be used for building any Rust applications (although sometimes there might be some stuff specific to each product, but those would probably be part of a specific build slave).

I removed the whole section on 'Building Crust', because I don't think it makes much sense to have a reference to Crust here. We should probably just leave the documentation in their own repositories to describe how to build each specific codebase. To me it's fairly obvious that these machines can be used as generic utility machines.

S-Coyle commented 5 years ago

Latest changes look good. Approved