search

mailgun / expiringdict

Dictionary with auto-expiring values for caching purposes.
Apache License 2.0
344 stars 76 forks source link

fix RuntimeError with Python 3.5 #27

Closed kophy closed 7 years ago

kophy commented 7 years ago
  1. fix Python 3.5 RuntimeError mentioned in issue #25
  2. add callback support for expired items (personally think it's useful)
horkhe commented 7 years ago

It is better not to mix a bug fix and a feature proposal in one PR.

kophy commented 7 years ago

Sure. Shall I remove callback part and make a new PR later? @horkhe

horkhe commented 7 years ago

yes, please

horkhe commented 7 years ago

@kophy please squash the changes and I will merge the PR.