search

mailjet / prestashop-mailjet-plugin-apiv3

GNU General Public License v2.0
15 stars 9 forks source link

trans() method not valid ps 1.6 #119

Closed vcopleutre closed 2 years ago

vcopleutre commented 2 years ago

File : mailjet.php Line : 1515

Incriminated code : 'title' => $this->trans('Settings', [], 'Admin.Global'),

Issue : the module is not 1.6 compliant due to this code.

Thanks for fixing it

Sekar33000 commented 2 years ago

Hello, same here, can't install in prestashop 1.6

[PrestaShop] Fatal error in module file : /modules/mailjet/mailjet.php: Uncaught Error: Call to undefined method Link::getTabLink() in /modules/mailjet/mailjet.php:1476 Stack trace: #0 /controllers/admin/AdminModulesController.php(868): Mailjet->getContent() #1 /controllers/admin/AdminModulesController.php(1117): AdminModulesControllerCore->postProcessCallback() #2 /classes/controller/Controller.php(178): AdminModulesControllerCore->postProcess() #3 /classes/Dispatcher.php(367): ControllerCore->run() #4 /override/classes/Dispatcher.php(22): DispatcherCore->dispatch() #5 admin/index.php(58): Dispatcher->dispatch() #6 {main} thrown

vcopleutre commented 2 years ago

Hi @Sekar33000 See my answer : https://github.com/mailjet/prestashop-mailjet-plugin-apiv3/issues/116#issuecomment-1057800957

Have a nice day

Sekar33000 commented 2 years ago

Thanks!

oleksandr-mykhailenko commented 2 years ago

Hello @vcopleutre you fixes was merged in scope of attached PR. Thank you for helping