search

mainio / decidim-module-term_customizer

Decidim module that allows customizing the localization terms in the system for specific contexts.
GNU Affero General Public License v3.0
15 stars 21 forks source link

Fix deprecation warning about positional arguments in Faker #81

Closed andreslucena closed 2 years ago

andreslucena commented 2 years ago

There were these kinds of warnings when running the specs:

./decidim-module-term_customizer/spec/models/decidim/term_customizer/translation_spec.rb:23: Passing word_count with the 1st argument of sentence is deprecated. Use keyword argument like sentence(word_count: ...) instead.

To automatically update from positional arguments to keyword arguments, install rubocop-faker and run:

rubocop \ --require rubocop-faker \ --only Faker/DeprecatedArguments \ --auto-correct

This PR fixes them

ahukkanen commented 2 years ago

Thanks @andreslucena but these are already fixed at develop.