maiyasaliha / pe

0 stars 0 forks source link

Find command does not find persons with half matched names #9

Open maiyasaliha opened 4 months ago

maiyasaliha commented 4 months ago

Given that half words are supposed to be matched, this following command does not find betsy and doe correctly

Example: find doe bet

only returns contacts with name Doe and not Betsy

This might be problematic as users are lead to think that there are no contacts matching bet.

image.png

image.png

image.png

soc-se-bot commented 4 months ago

Team's Response

Thank you raising this genuine concern. However, similar to issue 346 of which this is a duplicate of, this is a documentation bug on our part that says that substrings of names are allowed. However, we only intended keywords to be searched using the find command as can be seen in the command description, command format and app error message itself. As such search doe betsy will return both results and the way to resolve this is exactly the same as resolving issue 346. Changing our user guide to accept only keywords instead of substrings would resolve this duplicate issue.

image.png

image.png

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Adding various duplicate names to the person leads to find command not listing down the patients names

image.png

Upon adding a couple of patients with the same name but different NRIC.

image.png using Da as the keyword for finding names.

I am met with listing of 0 persons.

image.png

This could be the user not knowing if the keyword means that it has to be "David" in this scenario, leading to a misinterpretation


[original: nus-cs2103-AY2324S2/pe-interim#460] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for raising this. We acknowledge this is an issue, however, this is just a typo in the user guide and not a functionality bug in our programme. The error message in the actual MediCLI system states that find: Finds all persons whose names contain any of the specified keywords (case-insensitive) and displays them as a list with index numbers. (Screenshot attached below). The line you referenced was a typo as the overall description of the command in the user guide also states that it only accepts keywords.

Screenshot:

Screenshot 2024-04-20 at 3.14.33 PM.png

Screenshot 2024-04-20 at 3.15.33 PM.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** severity.Low: A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only. severity.Medium: A flaw that causes occasional inconvenience to some users, but they can continue to use the product. This is a flaw that does not only occur in rare situations as every time the user searches with a keyword that is half matched, MediCLI does not find accordingly. As such, normal operations like find are affected. This is a command that will be used often by users is the hospice setting. Moreover, both the application and the UG only say that (without contradiction -> both say the same) ![image.png](https://raw.githubusercontent.com/maiyasaliha/pe/main/files/db1dce12-5d7d-4e82-9788-af764efe8ccf.png) and this means that any given keyword will be matched, there is no restriction or specification that states that a keyword has to be a complete word and half a word is not a valid keyword. For example, explore is a valid keyword for explorer, although it is not fully matched. As such the severity of this bug aligns with the description of a Medium.