maize-genetics / phg_v2

Practical Haplotype Graph (PHG) version 2
https://phg.maizegenetics.net/
Apache License 2.0
21 stars 2 forks source link

initdb warning, updated yml file #218

Closed lynnjo closed 2 months ago

lynnjo commented 2 months ago

Description

Change warning message to info message when attempting to create tiledb datasets that already exist. Update tiledb versions in phg_environment.yml file.

Type of change

What type of changes does your code introduce? Put an x in boxes that apply.

Checklist:

Changelog entry

Please add a one-line changelog entry below. This will be copied to the changelog file during the release process.

Updated tiledb versions in phg_environment.yml file
Changed a warning message to an info message when creating tiledb datasets.
zrm22 commented 2 months ago

It failed the CI:

Looks like here: TileDBVcfReaderTest > testGvcfReading() FAILED java.lang.RuntimeException at TileDBVcfReaderTest.kt:57

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.72%. Comparing base (35548ae) to head (e284863). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...kotlin/net/maizegenetics/phgv2/cli/CreateRefVcf.kt 41.66% 4 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #218 +/- ## ========================================== - Coverage 82.82% 82.72% -0.11% ========================================== Files 77 77 Lines 5049 5060 +11 Branches 835 838 +3 ========================================== + Hits 4182 4186 +4 - Misses 556 560 +4 - Partials 311 314 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.