maize-genetics / phg_v2

Practical Haplotype Graph (PHG) version 2
https://phg.maizegenetics.net/
Apache License 2.0
21 stars 2 forks source link

Haplotype graph efficiency improvements #245

Closed tcasstevens closed 2 weeks ago

tcasstevens commented 2 weeks ago

Description

Provide a summary of your changes including motivation and context. If these changes fix a bug or resolves a feature request, be sure to link to that issue.

Type of change

What type of changes does your code introduce? Put an x in boxes that apply.

Checklist:

Changelog entry

Please add a one-line changelog entry below. This will be copied to the changelog file during the release process.

HaplotypeGraph performance improvements. fun getRanges(dbPath: String): Array<MutableList<Array<String?>>>
to
fun getRanges(dbPath: String): Map<ReferenceRange, Int>
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.10%. Comparing base (40abd69) to head (bd7ea87). Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
...tlin/net/maizegenetics/phgv2/api/HaplotypeGraph.kt 95.83% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #245 +/- ## ========================================== - Coverage 80.12% 80.10% -0.03% ========================================== Files 82 82 Lines 5827 5826 -1 Branches 1023 1023 ========================================== - Hits 4669 4667 -2 Misses 782 782 - Partials 376 377 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.