search

makamys / CoreTweaks

A bunch of random bug fixes, optimizations and tweaks (1.7.10)
MIT License
46 stars 5 forks source link

Incompatible with lwjgl3ify 1.5.1 #18

Closed sousuke0422 closed 1 year ago

sousuke0422 commented 1 year ago

I updated lwjgl3ify from 1.4.x and it stopped working

log: https://mclo.gs/8ihTP0j

image
SilearFlare commented 1 year ago

To be fair, lwjgl3ify is sort of a very heavy handed hack that breaks compat with most mods. Breakages are the norm, more than the exception.

charagarlnad commented 1 year ago

If you disable jar_discoverer_cache in the CoreTweaks config, the crash goes away.

SilearFlare commented 1 year ago

Oh hey, good call.

Although it does seem to be crashing with unimixins when neodymium is installed, citing some neodymium incompatibility. Not entirely sure it's an unimixins problem (which is slated for an update in the future) or a neodymium problem (which hasn't been updated since may) for the time being.

Oh, and it appears to be crashing with carpenter's blocks as well for some reason, even when using the latest GTNH release. And ominocular... And smart moving...

Yeah, good luck with this one

makamys commented 1 year ago

Pretty sure this was just an issue on my side, I initialized the jar discoverer cache really early, and it caused some other classes to get loaded earlier than normal, which broke LWJGL3ify's mixins that happened to be targeting those classes.

SilearFlare commented 1 year ago

**HE'S BACK** Cool, thanks. Any chance it might ever be possible to get smart moving to not crash with it eventually or it's one of those really up in the air things where both mods just change too much stuff to actually get them to work together properly?

makamys commented 1 year ago

IIRC that was a pretty simple issue on SM's side that I just never bothered to fix, will have a look at it later.