makamys / CoreTweaks

A bunch of random bug fixes, optimizations and tweaks (1.7.10)
MIT License
46 stars 5 forks source link

Ultramine incompatibility #35

Open SKProCH opened 7 months ago

SKProCH commented 7 months ago

Seems like DataWatcher mixin is incompatible with ultramine server core.

Here is the crashlog: https://gist.github.com/SKProCH/787a7640c25db49eea7af7e4ee6cf332

Coretweaks has watchedObjects that couldn't be located: https://github.com/makamys/CoreTweaks/blob/8fcebde2ce91a14cf40a5bb2b535f0c7d16bbbd5/src/main/java/makamys/coretweaks/mixin/diagnostics/detectdatawatcherconflict/MixinDataWatcher.java#L20

Seems like ultramine has WatchableObject[] watchedObjects, but coretweaks expect this is will be Map watchedObjects Here is Ultramine's DataWatcher class: https://github.com/AlexeyGrishankov/UltraMine/blob/9b80111a6ad168b94d56a58901661028c6e4356b/ultramine/ultrasource/src/main/java/net/minecraft/entity/DataWatcher.java#L27

Potential workaround: turn off detect_data_watcher_id_conflicts seems like everything is ok