search

makehumancommunity / mpfb2

MPFB2 is a free and open source human generator for Blender
http://static.makehumancommunity.org/mpfb.html
Other
323 stars 39 forks source link

Hardcoded local paths forgotten in blender4 nightly #164

Closed euhmeuh closed 6 months ago

euhmeuh commented 11 months ago

Fresh install of Blender 4 and the nightly build of mpfb2, blender4 branch

https://github.com/makehumancommunity/mpfb2/blob/f683f8ee904c3cb2b411d67995869630cd24116c/src/mpfb/entities/nodemodel/v2/composites/nodewrappermpfbsystemvaluetextureeyelids.py#L131

https://github.com/makehumancommunity/mpfb2/blob/f683f8ee904c3cb2b411d67995869630cd24116c/src/mpfb/entities/nodemodel/v2/composites/nodewrappermpfbsystemvaluetextureeyelids.py#L166

Hello! I think you forgot those hardcoded paths in your code. It's breaking the plugin when trying to apply any procedural skin to a model.

Cheers and thanks for your work on Blender 4 compatibility! I can't wait for those changes to be merged!

joepal1976 commented 11 months ago

Ouch. That's embarrassing.

I'm on it. Thanks for spotting the problem.

joepal1976 commented 11 months ago

This can't possibly have ever worked for anyone...

Anyway, I've pushed a fix now. It will be in tomorrow's nightly build or can be fetched from git.

euhmeuh commented 11 months ago

Yeah thanks for the quick reply! I'll test that tomorrow. Have a nice day! :grin: