search

makenai / node-uvc-control

Control UVC compliant USB webcams from node
80 stars 28 forks source link

UVC discovery #21

Closed positlabs closed 7 years ago

positlabs commented 7 years ago

@makenai I'll leave this as pending for a while in case you'd like to review.

positlabs commented 7 years ago

  1. I'm generally not a fan of semicolons since they don't really do anything except add cruft, but i'll update my code to match, since the precedent has already been set.

  2. Good idea re: engines field. I'd like to bump it up to 4.x eventually, since that the oldest LTS version still under maintenance.

  3. Heck yeah I'll take some credit for being a contributor :)

positlabs commented 7 years ago

I'm going to use v0.12 for the engines field, since it's an LTS version (v0.11 isn't)