search

makerbase-mks / MKS-SERVO42C

MKS SERVO42C, an upgraded version of MKS SERVO42B, built-in Field-Oriented control algorithm, position/speed/ torque closed-loop, 4 Half bridge driver with 8 MOSFET, it makes the motor quieter, lower vibration and Lower calorific.
139 stars 33 forks source link

Servo Control Tool is unusable #26

Open kutukvpavel opened 2 years ago

kutukvpavel commented 2 years ago
  1. Why would you manually try to open each port from COM1 to COM20, when an API exists to find all available ports accurately? SerialPort.GetPortNames(). I had to dig into the source code to understand why my COM21 was not detected. Do you consider COM port numbers >20 a very rare occasion? Well, they're not.
  2. V1.1 doesn't seem to be backwards compatible to V1.0 firmware (at least it doesn't work at all with a V1.0 device firmware). V1.0 lacks the ability to edit PID settings. Given that you haven't uploaded even a V1.1 firmware binary, I can't upgrade my devices, therefore I can't set up PID coefficients for my steppers at all now. Unless, of course, I write my own implementation of the control tool.
  3. I would've opened a pull request with some improvements, but you had neglected to set up a git source code repository for the tool here.
Nathan22211 commented 1 year ago

check the zips under the control tool folder. that's the source code and most of it is in 3 C# files. It's probably setup like that so github copilot/chatGPT doesn't grab the code