Closed D1plo1d closed 14 years ago
I filtered out some mis-commits (lots of skeinforge preferences), and removed the serial port locking code, but I've merged and pushed the rest. Feel free to explain what the serial locking code was good for.
(sorry, needed to reopen to comment)
Serial Locking: used to allow manual extruder control; 5D Gcode has no way to turn the extruder on and leave it running so a second thread is used to send a constant supply of G1 E100 commands until the extruder is turned off. Without serial locking you will get weird things happening when both threads try to write to serial at the same time (out of order line number, just in general unpredictable behavior). I thought it could be useful in the serial class for future multithreaded serial stuff but it could work just as well in the reprap 5d driver.
Skeinforge Settings: These settings are for Mendel RepRaps, I'd wanted to have them included in ReplicatorG like Makerbot's so that we can make them better as a community and make RepRap work out of the box like Makerbot does. I'm testing these settings a Mendel and Paul is testing on another. I forgot to mention them in the pull request (my bad!).
Re:SerialLocking, I take that back.. it needs to be in the SerialDriver to gaurentee the serial port isn't closed half way through sending a command.
Also thanks for the merge, I missed that point in my first comment, but it's awesome that this will end up in future versions of RepG!
OK, good points. I've merged both.
awesomes, thanks Kintel!
This patch includes:
update: fixed the missing files and various problems in this fork should be more stable and contain all files now.