Closed oddaf closed 3 months ago
TLDR: Good to deploy
0.8.16
true
IF spell introduces a major change that can affect external parties (e.g.: keepers are affected in case of collateral offboarding) OTHERWISE explicitly set to false
block.timestamp + 30 days
)TARGET_DATE MakerDAO Executive Spell | Hash: EXEC_DOC_HASH
TARGET_DATE
in the description matches the target date// Hash: cast keccak -- "$(wget 'EXEC_DOC_URL' -q -O - 2>/dev/null)"
// ----- Section text -----
)// Instruction text
// Note:
(e.g.: // Note: Payments are skipped on goerli
)chainlog
version bump), the necessity of it is explained in the comment above prefixed with // Note:
Reasoning URL
and Authority URL
is present in the spell code under relevant section or instruction (depending on which row the url is present)Reasoning URL
and Authority URL
have prefix derived from the url itself
// Executive Vote:
if URL starts with https://vote.makerdao.com/executive/
// Poll:
if URL starts with https://vote.makerdao.com/polling/
// Forum:
if URL starts with https://forum.makerdao.com/t/
// MIP:
if URL starts with https://mips.makerdao.com/mips/details/
foundryup
ℹ️ Updated versions:
foundryup: installed - forge 0.2.0 (afd8680 2024-08-21T00:19:11.446603000Z)
foundryup: installed - cast 0.2.0 (afd8680 2024-08-21T00:19:11.469127000Z)
foundryup: installed - anvil 0.2.0 (afd8680 2024-08-21T00:19:11.430428000Z)
foundryup: installed - chisel 0.2.0 (afd8680 2024-08-21T00:19:11.420822000Z)
rm -rf ./lib && git submodule update --init --recursive
Insert checked out submodule paths here
Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
Submodule path 'lib/dss-test': checked out '36ff4adbcb35760614e0d2df864026991c23d028'
dss-exec-lib
is synced as welldss-exec-lib
(run git submodule status
) matches the latest release version or newerdss-interfaces
library used inside lib/dss-exec-lib
matches submodule used inside lib/dss-test
dss-interfaces
dss-interfaces
import "dss-interfaces/dss/VatAbstract.sol";
)dss-interfaces
, OTHERWISE should be imported from there
:warning: PauseLike
is present as DSPauseAbstract
, but contains more methods that will be unused in this spell, so it's acceptable to re-declare the interface also by the previous conventioncast interface <contract_address>
commandLike
suffix (e.g. VatLike
)
WAD = 10 ** 18
RAY = 10 ** 27
RAD = 10 ** 45
internal
constant
HUNDRED = 10 ** 2
THOUSAND = 10 ** 3
MILLION = 10 ** 6
BILLION = 10 ** 9
internal
constant
make rates pct=<pct>
(e.g. pct=0.75, for 0.75%)X_PT_Y_Z_PCT_RATE
(e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE
for 0.75%)internal
constant
UTC
timezoneUTC
timezoneMMM_DD_YYYY
(e.g. JAN_01_2023
for 2023-01-01)23:59:59 UTC
for the final day of something, 00:00:00 UTC
for the first day of something)internal
constant
CRON_LITE_PSM_JOB_NEW
deployed to 0x0C86162ba3E507592fC8282b07cF18c7F902C401, with source code found in makerdao/dss-cronGNU AGPLv3
licensevat
, dai
, dog
, ...)
ℹ️
_sequencer
(address): 0x238b4E35dAed6100C6162fAE4510261f88996EC9
CRON_SEQUENCER
in the chainlog_litePsm
(address): 0xf6e72Db5454dd049d0788e411b06CfAF16853042
MCD_LITE_PSM_USDC_A
in the chainlog_rushThreshold
(uint256): 20_000_000_000000000000000000
_cutThreshold
(uint256): 300_000_000000000000000000
_gushThreshold
(uint256): 20_000_000_000000000000000000
wards
or access controlPAUSE_PROXY
address was relied
(wards(PAUSE_PROXY)
is 1
)denied
(wards(deployer)
is 0
)MCD_ESM
address is already relied OR being relied
(wards(MCD_ESM)
is 1
) in this spell (as approved by Governance Facilitators, in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy
)Rely
events except for PAUSE_PROXY
and MCD_ESM
(using a block explorer like etherscan)code --diff etherscan.sol github.sol
)addresses_deployers.sol
MCD_PAUSE.delay
is updated via PauseLike(MCD_PAUSE).setDelay
(as no relevant method is found in DssExecLib
)
jug.ilk.duty
) is updatedDssExecLib.setIlkStabilityFee(ilk, rate, doDrip)
) is used// Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%
pot.dsr
) is updatedDssExecLib.setDSR(rate, doDrip)
) is used// Increase DSR by X.XX% from X.XX% to X.XX%
make rates pct=<pct>
(e.g. pct=0.75, for 0.75%)spotter.ilk.mat
is updated, (DssExecLib.setIlkLiquidationRatio(ilk, pct_bps)
) is useddog.ilk.hole
is updated, (DssExecLib.setIlkMaxLiquidationAmount(ilk, amount)
) is usedvat.ilk.dust
is updated, (DssExecLib.setIlkMinVaultAmount(ilk, amount)
) is useddog.ilk.chop
is updated, (DssExecLib.setIlkLiquidationPenalty(ilk, pct_bps)
) is usedclip.buf
is updated, (DssExecLib.setStartingPriceMultiplicativeFactor(ilk, pct_bps)
) is usedclipperMom.clip.tolerance
is updated, (DssExecLib.setLiquidationBreakerPriceTolerance(clip, pct_bps)
) is usedclip.tail
is updated, (DssExecLib.setAuctionTimeBeforeReset(ilk, duration)
) is usedclip.cusp
is updated, (DssExecLib.setAuctionPermittedDrop(ilk, pct_bps)
) is usedclip.chip
is updated, (DssExecLib.setKeeperIncentivePercent(ilk, pct_bps)
) is usedclip.tip
is updated, (DssExecLib.setKeeperIncentiveFlatRate(ilk, amount)
) is usedcalc.tau
is updated, (DssExecLib.setLinearDecrease(calc, duration)
) is usedcalc.cut
or calc.step
are updated, DssExecLib.setStairstepExponentialDecrease(calc, duration, pct_bps)
is usedilk
) have AutoLine enabled (MCD_IAM_AUTO_LINE
)0
MCD_IAM_AUTO_LINE
) via DssExecLib.removeIlkFromAutoLine(ilk)
MCD_IAM_AUTO_LINE
) is present in the Exec Sheet0
via DssExecLib.setIlkDebtCeiling(ilk, amount)
vat.Line
) is updated accordingly, UNLESS specifically instructed not toAutoLine
parameters are updated
Update LITE-PSM-USDC-A DC-IAM
and Update PSM-USDC-A DC-IAM
), they are performed by the DssLitePsmMigrationPhase2
library using low-level call autoLine.setIlk
. That is not a problem, since the library was audited and unit checks (found in setIlkAutoLineParameters
) were performed manuallyDssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)
DssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl)
vat.ilk.line
) is updatedilk
) have AutoLine
disabled previously or in the spellvat.Line
) is updated accordingly, UNLESS specifically instructed not to, via EITHER:global
set to true
in increaseIlkDebtCeiling
/decreaseIlkDebtCeiling
DssExecLib.setGlobalDebtCeiling(amount)
DssExecLib.increaseGlobalDebtCeiling(amount)
DssExecLib.decreaseGlobalDebtCeiling(amount)
./src/dependencies/
directory) are present:
2f11f4bc47d96f4ebf025a1e4a249987150f9baa
src/dependencies/dss-lite-psm/phase-2/DssLitePsmMigrationPhase2.sol
matches audited source code found at https://github.com/makerdao/dss-lite-psm/blob/2f11f4bc47d96f4ebf025a1e4a249987150f9baa/src/deployment/phase-2/DssLitePsmMigrationPhase2.solsrc/dependencies/dss-lite-psm/DssLitePsmMigration.sol
matches audited source code found at https://github.com/makerdao/dss-lite-psm/blob/2f11f4bc47d96f4ebf025a1e4a249987150f9baa/src/deployment/DssLitePsmMigration.solIF PSM migration, onboarding or offboarding is present:
dstWant
) matches the Exec SheetsrcKeep
) matches the Exec Sheettin
matches the value in the Exec Sheettout
matches the value in the Exec SheetAutoLine
is updated according to the Exec Sheettin
matches the value in the Exec Sheettout
matches the value in the Exec SheetAutoLine
is updated according to the Exec Sheetbuf
matches the value in the Exec Sheetfill
is called conditionally (if(rush() > 0)
) to ensure liquidity is immediately available after spell executionvat.urns(DST_ILK, dstPsm).art
is increased at least by the moved amountgem
balance of dstPocket
is increased exactly by the moved amountdstPsm
is equal to dstBuf
, UNLESS limited by the debt ceiling (line
)vat.urns(SRC_ILK, srcPsm).art
is decreased exactly by the moved amountvat.urns(SRC_ILK, srcPsm).ink
is decreased exactly by the moved amountgem
balance of srcPsm.gemJoin()
is decreased exactly by the moved amountvat.vice()
is unchanged after the spell executionvat.sin(MCD_PAUSE_PROXY)
is unchanged after the spell executionDssLitePsm
200
forge verify-bytecode
LITE-PSM-{TOKEN_SYMBOL}-A
(i.e. LITE-PSM-USDC-A
)gem
matches the expected token addressdaiJoin
matches MCD_JOIN_DAI
from the chainlogpocket
matches the pocket address in the Exec Sheetwards(deployer) == 0
)MCD_PAUSE_PROXY
has been authed (i.e. require(WardsLike({LITE_PSM}).wards(MCD_PAUSE_PROXY) == 1)
)DssLitePsm
has type(uint256).max
approval to spend gem
on behalf of pocket
LitePsmJob
ℹ️ deployed to 0x0C86162ba3E507592fC8282b07cF18c7F902C401
dss-cron
_sequencer
matches CRON_SEQUENCER
address from the chainlog_litePsm
matches {LITE_PSM}
address_rushThreshold
matches the Exec Sheet (it might be named as "fill threshold")_gushThreshold
matches the Exec Sheet (it might be named as "trim threshold")_cutThreshold
matches the Exec Sheet (it might be named as "chug threshold")DssLitePsm
:buf
is set to the value specified in the Exec Sheetvow
is set to MCD_VOW
from the chainlogMCD_PAUSE_PROXY
is whitelisted to execute swaps with no fees (i.e. KissLike({LITE_PSM}).kiss(MCD_PAUSE_PROXY)
)DssLitePsmMom
is authed (i.e. RelyLike({LITE_PSM}).rely(MOM)
)LitePsmJob
:CRON_SEQUENCER
MCD_VAT
:MCD_JUG
:MCD_SPOT
:par
) current value is 1 (1 * RAY
)mat
) is set to 100% (1 * RAY
) for the ilkpip
is being used:pip
is set for the ilkpip
is a DSValue
instancepip
is set to 1 (1 * WAD
)pip
deployer is no longer the owner
MCD_PAUSE_PROXY
is the owner
on pip
pip
:pip
is set for the ilkpip
in the chainlog matches gem
symbol (i.e. PIP_USDC
for USDC
)ILK_REGISTRY
:CHAINLOG
:DssLitePsm
is added to the chainlog and addresses_mainnet.sol
according to the Exec Sheetpocket
is added to the chainlog and addresses_mainnet.sol
according to the Exec SheetDssLitePsmMom
is added to the chainlog and addresses_mainnet.sol
according to the Exec SheetLitePsmJob
is added to the chainlog and addresses_mainnet.sol
according to the Exec Sheetpip
is being added, it is added to the chainlog and addresses_mainnet.sol
as PIP_{TOKEN_SYMBOL}
(i.e. PIP_USDC
)DssLitePsm
: ℹ️ Tested via testLitePSMs
vow
is set to MCD_VOW
buf
matches the Exec SheetMCD_PAUSE_PROXY
is whitelisted to execute swaps with no fees (i.e. KissLike({LITE_PSM}).bud(MCD_PAUSE_PROXY) == 1
)DssLitePsmMom
is authed (i.e. WardsLike({LITE_PSM}).wards(MOM) == 1
)~~buyGem
works as expectedsellGem
works as expectedbuyGemNoFee
works as expectedsellGemNoFee
works as expectedDssLitePsmMom
: ℹ️ Tested via testLitePSMs
halt
prevents new swaps in {LITE_PSM}
LitePsmJob
: ℹ️ Tested via test_CRON_LITE_PSM_JOB
CRON_SEQUENCER
(i.e.: SequencerLike(CRON_SEQUENCER).hasJob(LITE_PSM_JOB) == true
)sequencer
matches CRON_SEQUENCER
address from the chainloglitePsm
matches {LITE_PSM}
addressrushThreshold
matches the Exec Sheet (it might be named as "fill threshold")gushThreshold
matches the Exec Sheet (it might be named as "trim threshold")cutThreshold
matches the Exec Sheet (it might be named as "chug threshold")work
has the desired effect:
rush() > _rushThreshold
, fill
is calledcut() > _cutThreshold
, chug
is calledgush() > _gushThreshold
, trim
is calledMCD_VAT
: ℹ️ Tested via testLitePSMs
urns[ilk][{LITE_PSM}].ink
is set to the max value that will not cause an overflow (int256(type(uint256).max / RAY)
)MCD_JUG
: ℹ️ Tested via testGeneral
duty
) is set to 0% (1 * RAY
) for the ilk (:information_source: covered in config.sol
)MCD_SPOT
: ℹ️ Tested via testGeneral
spotter(DST_ILK).mat
is set to 100% (1 * RAY
) (:information_source: covered in config.sol
)spotter(DST_ILK).pip
is set correctlyCHAINLOG
: ℹ️ It is indeed bumped, but for another reason
{x}.{y}.{z+1}
(:information_source: covered in config.sol
)ILK_REGISTRY
: ℹ️ Tested via testLitePSMs
name
matches gem
namesymbol
matches gem
symbolclass
for join-less ilks is used (REG_CLASS = 6
)gem
matches the configured gempip
matches the configured pipgemJoin
is set to address(0)
clip
is set to address(0)
ilk
) is removed from AutoLine (MCD_IAM_AUTO_LINE
) IF currently enabledvat.ilk.line
) is set to 0
vat.Line
) decreased by the total amount of offboarded ilkschop
) is set to 0
IF requested by governancetip
) is set to 0
IF requested by governancechip
) is set to 0
IF requested by governancehole
) is adjusted via DssExecLib.setIlkMaxLiquidationAmount(ilk, amount)
IF requested by governanceMCD_CLIP_
) is active (i.e. stopped
is 0
)spotter.ilk.mat
) being set very high in the spell (using DssExecLib.setValue(DssExecLib.spotter(), ilk, "mat", ratio)
)DssExecLib.linearInterpolation(name, target, ilk, what, startTime, start, end, duration)
)name
format matches "XXX-X Offboarding"target
matches DssExecLib.spotter()
addressilk
format matches collateral type (ilk
) name ("XXX-X"
)what
matches string "mat"
startTime
matches block.timestamp
start
uses variable CURRENT_XXX_A_MAT
start
matches current spotter.ilk.mat
valueend
uses variable TARGET_XXX_A_MAT
end
value matches the instructionend
allows liquidation of all remaining vaults (end
is bigger than collateral_type_collateralization_ratio * risk_multiplier_factor
)duration
matches the instructionDssExecLib.updateCollateralPrice(ilk)
IF collateral have no running oracle (i.e. relevant PIP_
contract have outdated zzz
value)_checkIlkClipper
helperDssExecLib.setContract
(for regular conduits) or using low-level slap
+clap
(for the MultiSwap conduit)
doc
is updated_updateDoc
helper is copied one-to-one from the archive and defined above actions
_updateDoc(ilk, doc)
is called in the spellDssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl)
or DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)
vat.ilk.line
) update is requested by the Exec Sheetilk
) have AutoLine
disabled previously or in the spellvat.ilk.line
) is updated, via EITHER:vat.Line
) is updated accordingly, UNLESS specifically instructed not to, via EITHER:global
set to true
in increaseIlkDebtCeiling
/decreaseIlkDebtCeiling
DssExecLib.setGlobalDebtCeiling(amount)
DssExecLib.increaseGlobalDebtCeiling(amount)
DssExecLib.decreaseGlobalDebtCeiling(amount)
RwaLiquidationOracleLike(MIP21_LIQUIDATION_ORACLE).bump(ilk, val)
patternbump
explains val
computation via // Note: the formula is: "debt_ceiling * [ (1 + rwa_stability_fee ) ^ (minimum_deal_duration_in_years) ] * liquidation_ratio"
bump
provides locally executable formula (e.g. // bc -l <<< 'scale=18; 50000000 * e(l(1.07) * (3342/365)) * 1.00' | cast --to-wei
)debt_ceiling
in the executable formula matches new debt ceiling set in the spell or the maximum possible debt ceiling in case of the enabled AutoLinerwa_stability_fee
in the executable formula matches stability fee of the specified RWA found on chainminimum_deal_duration_in_years
in the executable formula matches number found in the Exec Sheet of the spell containing relevant RWA onboardingliquidation_ratio
in the executable formula matches liquidation ratio of the specified RWA found on chainval
in the spellval
makes sense in context of the rate mechanismval
calculation is done once per ilk and added to make the total, with separate executable formulas provided in comments. The existing val
value can be retrieved by calling read()
on PIP_RWAXX
and converting the result into decimalDssExecLib.updateCollateralPrice(ilk)
.tell(ilk)
) AND debt ceiling is 0
(OR is being set to 0
in the current spell)RwaLiquidationOracle.tell(ilk)
call is presentRWAXX_A_INPUT_CONDUIT
is an instance of TinlakeMgr
(it is a Centrifuge integration), additional TinlakeMgr.tell()
call is present (in order to prevent further TIN
redemptions in the Centrifuge pool)MKR
transfers are presentaddresses_wallets.sol
ether
keywordether
keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred here
testMKRPayments
testtestMKRPayments
matches number in the Exec SheetDAI
surplus buffer transfers are presentaddresses_wallets.sol
testDAIPayments
testtestDAIPayments
matches number in the Exec SheetMKR
or DAI
streams (DssVest
) are createdVestAbstract
interface is imported from dss-interfaces/dss/VestAbstract.sol
restrict
is used for each stream, UNLESS otherwise explicitly stated in the Exec Sheetusr
(Vest recipient address) matches Exec Sheetusr
address in the instruction is in the checksummed formatusr
address variable name match one found in addresses_wallets.sol
tot
(Total stream amount) matches Exec Sheetether
keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred here
bgn
(Vest start timestamp) matches Exec Sheettau
is expressed as bgn - fin
(i.e. MONTH_DD_YYYY - MONTH_DD_YYYY
)fin
(Vest end timestamp) matches Exec Sheeteta
(Vest cliff duration) matches the following logiceta
is explicitly specified in the Exec Sheet, then the values matcheta
and clf
(Cliff end timestamp) are not specified in the Exec Sheet, then eta
is 0
clf
is specified, but clf <= bgn
, then eta
is 0
clf
is specified and clf > bgn
, eta
is expressed as clf - bgn
(i.e. MONTH_DD_YYYY - MONTH_DD_YYYY
)mgr
(Vest manager address) is specified in the Exec Sheet, matches the value, OTHERWISE matches address(0)
cap
) is enough for the new streamstot
divided by tau
) <=
the maximum vest streaming rate (cap
)tot
divided by tau
) >
the maximum vest streaming rate (cap
)cap
value equal to 10% greater than the new maximum vesting rate, then round new cap
up with 2 significant figure precision (i.e. 2446 becomes 2500)cap
) is changed in the spelltotal
(the sum of all tot
values)testVestDAI
or testVestMKR
MKR
or DAI
vest termination (Yank
) is presentMCD_VEST_MKR_TREASURY
chainlog address is used for MKR stream yank
MCD_VEST_DAI
chainlog address is used for DAI stream yank
testYankDAI
or testYankMKR
ProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));
addresses_deployers.sol
as an entryDelegateCall
context)vat
, etc. (Check comprehensively where the risk is high)PAUSE_PROXY
as their admin
(i.e. the party that can upgrade)admin
that is not PAUSE_PROXY
are not authed on any core contracts (Blocking)delegatecall
CREATE2
(e.g. if it looks like a vanity address) do not have selfdestruct
in their codeaddresses_mainnet.sol
testChainlogIntegrity
and testChainlogValues
public
/internal
immutable
visibility is only used when fetching addresses from the ChainLog
via DssExecLib.getChangelogAddress(key)
and constant
is used instead for static addresses
address
and wrap with Like
suffix interfaces inline (when making calls), UNLESS archive patterns permit otherwise (Such as MKR
)DssExecLib.vat()
)ChainLog
, the variable name must match the value of the ChainLog key for that address (e.g. MCD_VAT
rather than vat
), except where the archive pattern differs from this pattern (e.g. MKR)DssExecLib.address
file is not being modified by the spell PRpublic
skipped
modifier; OTHERWISE, it MUST have the skipped
modifiertestGeneral
testRwaConduitsPsmUpdate
test_LITE_PSM_USDC_A_MigrationPhase2
and testLitePSMs
test_LITE_PSM_USDC_A_MigrationPhase2
and testPSMs
testGeneral
test_LITE_PSM_USDC_A_MigrationPhase2
testGeneral
testGeneral
test_CRON_LITE_PSM_JOB
testChainlogIntegrity
and testChainlogValues
printenv | grep "FOUNDRY_\|DAPP_"
)make test
[PASS]
prefix.
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠰] Compiling 4 files with Solc 0.8.16
[⠒] Solc 0.8.16 finished in 2.39s
Compiler run successful!
Ran 2 tests for src/test/starknet.t.sol:StarknetTests [PASS] testStarknet() (gas: 1661004) [PASS] testStarknetSpell() (gas: 2324) Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 42.14s (35.70s CPU time)
Ran 37 tests for src/DssSpell.t.sol:DssSpellTest [SKIP] testBytecodeMatches() (gas: 0) [PASS] testCastCost() (gas: 1518180) [PASS] testCastOnTime() (gas: 1515054) [PASS] testChainlogIntegrity() (gas: 6064209) [PASS] testChainlogValues() (gas: 9989256) [SKIP] testCollateralIntegrations() (gas: 0) [PASS] testContractSize() (gas: 11184) [SKIP] testDAIPayments() (gas: 0) [SKIP] testDaoResolutions() (gas: 0) [PASS] testDeployCost() (gas: 4623035) [SKIP] testEsmAuth() (gas: 0) [PASS] testGeneral() (gas: 30353837) [SKIP] testIlkClipper() (gas: 0) [SKIP] testL2ArbitrumSpell() (gas: 0) [SKIP] testL2OptimismSpell() (gas: 0) [SKIP] testLerpSurplusBuffer() (gas: 0) [PASS] testLitePSMs() (gas: 2441071) [SKIP] testMKRPayments() (gas: 0) [SKIP] testMedianizers() (gas: 0) [SKIP] testNewIlkRegistryValues() (gas: 0) [PASS] testNextCastTime() (gas: 446546) [SKIP] testOSMs() (gas: 0) [SKIP] testOffboardings() (gas: 0) [PASS] testOfficeHours() (gas: 495684) [SKIP] testOracleList() (gas: 0) [PASS] testPSMs() (gas: 2823452) [SKIP] testRemoveChainlogValues() (gas: 0) [PASS] testRevertIfNotScheduled() (gas: 17507) [PASS] testRwaConduitsPsmUpdate() (gas: 1586080) [SKIP] testSparkSpellIsExecuted() (gas: 0) [PASS] testUseEta() (gas: 352730) [SKIP] testVestDAI() (gas: 0) [SKIP] testVestMKR() (gas: 0) [SKIP] testYankDAI() (gas: 0) [SKIP] testYankMKR() (gas: 0) [PASS] test_CRON_LITE_PSM_JOB() (gas: 2687698) [PASS] test_LITE_PSM_USDC_A_MigrationPhase2() (gas: 1588161) Suite result: ok. 16 passed; 0 failed; 21 skipped; finished in 380.81s (869.22s CPU time)
Ran 2 test suites in 381.60s (422.96s CPU time): 18 tests passed, 0 failed, 21 skipped (39 total tests)
## Pre-Deployment Stage
* [x] Wait till the Exec Doc is merged
* Exec Doc checks
* [x] Exec Doc for the specified date is found in the [`makerdao/community` GitHub repo](https://github.com/makerdao/community/tree/master/governance/votes)
ℹ️ https://github.com/makerdao/community/blob/8d95eaf1c9eb6722008172504df88bc27f91ed3c/governance/votes/Executive%20vote%20-%20August%2022%2C%202024.md
* [x] Exec Doc file name follows the format `Executive vote - Month DD, YYYY.md`
* [x] Extract _permanent_ URL to the raw markdown file and paste it below
_Insert your Raw Exec Doc URL here_
https://raw.githubusercontent.com/makerdao/community/8d95eaf1c9eb6722008172504df88bc27f91ed3c/governance/votes/Executive%20vote%20-%20August%2022%2C%202024.md
* [ ] Using Exec Doc URL from the above and the `TARGET_DATE`, generate Exec Doc Hash via `make exec-hash date=$TARGET_DATE $URL`
_Insert your Exec Doc Hash here_
:warning: Script fails with `date: illegal option -- d`, but the hash is generated via the command below
* [x] Using Exec Doc URL from the above, generate Exec Doc Hash via `cast keccak -- "$(curl '$URL' -o - 2>/dev/null)"`
_Insert your Exec Doc Hash here_
0xe3794c8152d2a1de72080b1fc7d8429a979015b3f41cbe2c26f755724c70951d
* [x] Make sure that hash above doesn't match `keccak` hash of the empty string (`0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470`)
* [x] Using Exec Doc URL from the above, read spell instructions from the Exec Doc and list them below
_List all instructions announced in the Exec Doc_
- __PSM state variables in the following conduit contracts will be updated to point to MCD_LITE_PSM_USDC_A__
- RWA014_A_INPUT_CONDUIT_URN
- RWA014_A_INPUT_CONDUIT_JAR
- RWA014_A_OUTPUT_CONDUIT
- RWA007_A_JAR_INPUT_CONDUIT
- RWA007_A_INPUT_CONDUIT
- RWA007_A_OUTPUT_CONDUIT
- RWA015_A_INPUT_CONDUIT_JAR_USDC
- RWA015_A_INPUT_CONDUIT_URN_USDC
- RWA015_A_OUTPUT_CONDUIT
- RWA009_A_INPUT_CONDUIT_URN_USDC
- __Migrate Reserves from PSM-USDC-A to LITE-PSM-USDC-A__
- all but 200 million USDC reserves from PSM-USDC-A will be migrated to LITE-PSM-USDC-A.
- __PSM-USDC-A fees will be updated__
- PSM-USDC-A Fee In (tin) will be increased by 0.01 percentage points from 0% to 0.01%.
- PSM-USDC-A Fee Out (tout) will be increased by 0.01 percentage points from 0% to 0.01%.
- __PSM-USDC-A DC-IAM parameters below will be updated as follows__
- PSM-USDC-A DC-IAM Maximum Debt Ceiling (line) will be decreased by 7,500 million DAI from 10,000 million DAI to 2,500 million DAI.
- PSM-USDC-A DC-IAM Target Available Debt (gap) will be decreased by 180 million DAI from 380 million DAI to 200 million DAI.
- PSM-USDC-A DC-IAM Ceiling Increase Cooldown (ttl) will remain unchanged at 12 hours.
- __Update MCD_LITE_PSM_USDC_A buf__
- MCD_LITE_PSM_USDC_A Fixed-sized Amount of Pre-minted Dai (buf) will be increased by 180 million DAI from 20 million DAI to 200 million DAI.
- __Update LITE-PSM-USDC-A DC-IAM Parameters__
- LITE-PSM-USDC-A DC-IAM Maximum Debt Ceiling (line) will be increased by 7,450 million DAI from 50 million DAI to 7,500 million DAI.
- LITE-PSM-USDC-A DC-IAM Target Available Debt (gap) will be increased by 180 million DAI from 20 million DAI to 200 million DAI.
- LITE-PSM-USDC-A DC-IAM Ceiling Increase Cooldown (ttl) will remain unchanged at 12 hours.
- __Update GSM Delay__
- The GSM Pause Delay will be increased by 14 hours from 16 hours to 30 hours.
- __Update LitePSM Keeper Network Job__
- The old LitePSM job will be removed from the CronSequencer through contract call sequencer.removejob(0x689cE517a4DfCf0C5eC466F2757D324fc292C8Be).
- The new LitePSM job will be added to the CronSequencer through contract call sequencer.addjob(0x0c86162ba3e507592fc8282b07cf18c7f902c401).
- fill: The rushThreshold will be set to 20 million DAI.
- trim: The gushThreshold will be set to 20 million DAI.
- chug: The cutThreshold will remain unchanged at 300,000 DAI.
- The chainlog entry for CRON_LITE_PSM_JOB will be updated to 0x0c86162ba3e507592fc8282b07cf18c7f902c401.
* [x] Office hours value in the Exec Doc matches the spell
* [ ] ~~Sum of all payments in the Exec Doc matches the tests~~
* [x] Exec Doc URL in the spell comment matches your Raw Exec Doc URL above
* [x] Exec Doc URL in the spell comment refers to the [https://github.com/makerdao/community](https://github.com/makerdao/community/tree/master/governance/votes) repository
* [x] Every action present in the spell code is present in the Exec Doc
* [x] Every action in the Exec Doc is present in the spell code
* ~~IF new commits are present in the spell~~
* [ ] ~~Copy relevant checklist items from the above and redo them~~
* [ ] ~~Ensure newly added code is covered by tests~~
* [ ] ~~Check if chainlog needs to be updated~~
* [ ] ~~Copy over and redo "Tests" section from the above~~
* [x] IF all checks pass, make sure to include explicit "Good to deploy" comment
Preparation
[x] Exec Sheet for the specified date is found in the "Executive Vote Implementation Process" google sheet Insert URL to the specific sheet here https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw/edit?gid=175785542#gid=175785542
[x] Using Exec Sheet URL from the above, read spell instructions from the Exec Sheet and list them below List all instructions announced in the Exec Sheet
Update PSM-USDC-A DC-IAM Update PSM state variable in the conduit contracts to MCD_LITE_PSM_USDC_A
Phase 2 USDC Migration from PSM-USDC-A to LITE-PSM-USDC-A
Update PSM-USDC-A Fees
Update PSM-USDC-A DC-IAM
Update MCD_LITE_PSM_USDC_A Buf
Update LITE-PSM-USDC-A DC-IAM
GSM Delay Update
Update LitePSM Keeper Network Job
Base checks
0.8.16
true
IF spell introduces a major change that can affect external parties (e.g.: keepers are affected in case of collateral offboarding) OTHERWISE explicitly set to false
block.timestamp + 30 days
)Spell description
TARGET_DATE MakerDAO Executive Spell | Hash: EXEC_DOC_HASH
TARGET_DATE
in the description matches the target date// Hash: cast keccak -- "$(wget 'EXEC_DOC_URL' -q -O - 2>/dev/null)"
Comments inside the spell
// ----- Section text -----
)// Instruction text
// Note:
(e.g.: // Note: Payments are skipped on goerli
)chainlog
version bump), the necessity of it is explained in the comment above prefixed with // Note:
Reasoning URL
and Authority URL
is present in the spell code under relevant section or instruction (depending on which row the url is present)Reasoning URL
and Authority URL
have prefix derived from the url itself
// Executive Vote:
if URL starts with https://vote.makerdao.com/executive/
// Poll:
if URL starts with https://vote.makerdao.com/polling/
// Forum:
if URL starts with https://forum.makerdao.com/t/
// MIP:
if URL starts with https://mips.makerdao.com/mips/details/
Dependency checks
foundryup
rm -rf ./lib && git submodule update --init --recursive
Insert checked out submodule paths here
Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
Submodule path 'lib/dss-exec-lib/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
Submodule path 'lib/dss-exec-lib/lib/forge-std': checked out '0aa99eb8456693c015350c5e6c4f442ebe912f77'
Submodule path 'lib/dss-exec-lib/lib/forge-std/lib/ds-test': checked out 'cd98eff28324bfac652e63a239a60632a761790b'
Submodule path 'lib/dss-test': checked out '36ff4adbcb35760614e0d2df864026991c23d028'
Submodule path 'lib/dss-test/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
Submodule path 'lib/dss-test/lib/forge-std': checked out '155d547c449afa8715f538d69454b83944117811'
Submodule path 'lib/dss-test/lib/forge-std/lib/ds-test': checked out 'e282159d5170298eb2455a6c05280ab5a73a4ef0'
dss-exec-lib
is synced as welldss-exec-lib
(run git submodule status
) matches the latest release version or newerdss-interfaces
library used inside lib/dss-exec-lib
matches submodule used inside lib/dss-test
IF interfaces are present in the spell
dss-interfaces
dss-interfaces
import "dss-interfaces/dss/VatAbstract.sol";
)
ℹ️ Not done, but not critical!dss-interfaces
, OTHERWISE should be imported from there
ℹ️ Skipped for convenience in some casescast interface <contract_address>
commandLike
suffix (e.g. VatLike
)
IF variable declarations are present in the spell
WAD = 10 ** 18
RAY = 10 ** 27
RAD = 10 ** 45
internal
constant
HUNDRED = 10 ** 2
THOUSAND = 10 ** 3
MILLION = 10 ** 6
BILLION = 10 ** 9
internal
constant
make rates pct=<pct>
(e.g. pct=0.75, for 0.75%)X_PT_Y_Z_PCT_RATE
(e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE
for 0.75%)internal
constant
UTC
timezoneUTC
timezoneMMM_DD_YYYY
(e.g. JAN_01_2023
for 2023-01-01)for the final day of something,
00:00:00 UTC` for the first day of something)~~internal
constant
IF new contract is present in the spell (not yet on chainlog or new to chainlog)
GNU AGPLv3
licensevat
, dai
, dog
, ...)wards
or access controlPAUSE_PROXY
address was relied
(wards(PAUSE_PROXY)
is 1
)denied
(wards(deployer)
is 0
)MCD_ESM
address is already relied OR being relied
(wards(MCD_ESM)
is 1
) in this spell (as approved by Governance Facilitators, in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy
)Rely
events except for PAUSE_PROXY
and MCD_ESM
(using a block explorer like etherscan)code --diff etherscan.sol github.sol
)addresses_deployers.sol
IF core system parameter changes are present in the instructions
jug.ilk.duty
) is updatedDssExecLib.setIlkStabilityFee(ilk, rate, doDrip)
) is used// Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%
pot.dsr
) is updatedDssExecLib.setDSR(rate, doDrip)
) is used// Increase DSR by X.XX% from X.XX% to X.XX%
make rates pct=<pct>
(e.g. pct=0.75, for 0.75%)spotter.ilk.mat
is updated, (DssExecLib.setIlkLiquidationRatio(ilk, pct_bps)
) is useddog.ilk.hole
is updated, (DssExecLib.setIlkMaxLiquidationAmount(ilk, amount)
) is usedvat.ilk.dust
is updated, (DssExecLib.setIlkMinVaultAmount(ilk, amount)
) is useddog.ilk.chop
is updated, (DssExecLib.setIlkLiquidationPenalty(ilk, pct_bps)
) is usedclip.buf
is updated, (DssExecLib.setStartingPriceMultiplicativeFactor(ilk, pct_bps)
) is usedclipperMom.clip.tolerance
is updated, (DssExecLib.setLiquidationBreakerPriceTolerance(clip, pct_bps)
) is usedclip.tail
is updated, (DssExecLib.setAuctionTimeBeforeReset(ilk, duration)
) is usedclip.cusp
is updated, (DssExecLib.setAuctionPermittedDrop(ilk, pct_bps)
) is usedclip.chip
is updated, (DssExecLib.setKeeperIncentivePercent(ilk, pct_bps)
) is usedclip.tip
is updated, (DssExecLib.setKeeperIncentiveFlatRate(ilk, amount)
) is usedcalc.tau
is updated, (DssExecLib.setLinearDecrease(calc, duration)
) is usedcalc.cut
or calc.step
are updated, DssExecLib.setStairstepExponentialDecrease(calc, duration, pct_bps)
is usedIF debt ceiling changes are present in the instructions
ilk
) have AutoLine enabled (MCD_IAM_AUTO_LINE
)0
MCD_IAM_AUTO_LINE
) via DssExecLib.removeIlkFromAutoLine(ilk)
MCD_IAM_AUTO_LINE
) is present in the Exec Sheet0
via DssExecLib.setIlkDebtCeiling(ilk, amount)
vat.Line
) is updated accordingly, UNLESS specifically instructed not toAutoLine
parameters are updated
DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)
DssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl)
ℹ️ Neither is used but not a problem since it is made via autoLine.setIlk()
in the migration script!vat.ilk.line
) is updatedilk
) have AutoLine
disabled previously or in the spellvat.Line
) is updated accordingly, UNLESS specifically instructed not to, via EITHER:global
set to true
in increaseIlkDebtCeiling
/decreaseIlkDebtCeiling
DssExecLib.setGlobalDebtCeiling(amount)
DssExecLib.increaseGlobalDebtCeiling(amount)
DssExecLib.decreaseGlobalDebtCeiling(amount)
IF additional dependencies (i.e. ./src/dependencies/
directory) are present:
dss-lite-psm
repo which contains the following audits:
IF onboarding is present
IF PSM migration, onboarding or offboarding is present:
dstWant
) matches the Exec SheetsrcKeep
) matches the Exec Sheettin
matches the value in the Exec Sheettout
matches the value in the Exec SheetAutoLine
is updated according to the Exec Sheettin
matches the value in the Exec Sheettout
matches the value in the Exec SheetAutoLine
is updated according to the Exec Sheet~~buf
matches the value in the Exec Sheetfill
is called conditionally (if(rush() > 0)
) to ensure liquidity is immediately available after spell executionvat.urns(DST_ILK, dstPsm).art
is increased at least by the moved amountgem
balance of dstPocket
is increased exactly by the moved amountdstPsm
is equal to dstBuf
, UNLESS limited by the debt ceiling (line
)vat.urns(SRC_ILK, srcPsm).art
is decreased exactly by the moved amountvat.urns(SRC_ILK, srcPsm).ink
is decreased exactly by the moved amountgem
balance of srcPsm.gemJoin()
is decreased exactly by the moved amountvat.vice()
is unchanged after the spell executionvat.sin(MCD_PAUSE_PROXY)
is unchanged after the spell executionDssLitePsmMom
200
forge verify-bytecode
owner
MCD_PAUSE_PROXY
is the owner
of the contract (i.e. require(MomLike(MOM).owner() == MCD_PAUSE_PROXY
))DssLitePsmMom
:MCD_ADM
) is set as the authority
(i.e. MomLike(MOM).setAuthority(MCD_ADM)
)DssLitePsmMom
:MCD_ADM
) is set as the authority
(i.e. MomLike(MOM).setAuthority(MCD_ADM)
)DssLitePsm
200
forge verify-bytecode
LITE-PSM-{TOKEN_SYMBOL}-A
(i.e. LITE-PSM-USDC-A
)gem
matches the expected token addressdaiJoin
matches MCD_JOIN_DAI
from the chainlogpocket
matches the pocket address in the Exec Sheetwards(deployer) == 0
)MCD_PAUSE_PROXY
has been authed (i.e. require(WardsLike({LITE_PSM}).wards(MCD_PAUSE_PROXY) == 1)
)DssLitePsm
has type(uint256).max
approval to spend gem
on behalf of pocket
LitePsmJob
dss-cron
_sequencer
matches CRON_SEQUENCER
address from the chainlog_litePsm
matches {LITE_PSM}
address_rushThreshold
matches the Exec Sheet (it might be named as "fill threshold")_gushThreshold
matches the Exec Sheet (it might be named as "trim threshold")_cutThreshold
matches the Exec Sheet (it might be named as "chug threshold")DssLitePsm
:buf
is set to the value specified in the Exec Sheetvow
is set to MCD_VOW
from the chainlogMCD_PAUSE_PROXY
is whitelisted to execute swaps with no fees (i.e. KissLike({LITE_PSM}).kiss(MCD_PAUSE_PROXY)
)DssLitePsmMom
is authed (i.e. RelyLike({LITE_PSM}).rely(MOM)
)LitePsmJob
:
CRON_SEQUENCER
MCD_VAT
:MCD_JUG
:MCD_SPOT
:par
) current value is 1 (1 * RAY
)mat
) is set to 100% (1 * RAY
) for the ilkpip
is being used:pip
is set for the ilkpip
is a DSValue
instancepip
is set to 1 (1 * WAD
)pip
deployer is no longer the owner
MCD_PAUSE_PROXY
is the owner
on pip
pip
:pip
is set for the ilkpip
in the chainlog matches gem
symbol (i.e. PIP_USDC
for USDC
)ILK_REGISTRY
:CHAINLOG
:
DssLitePsm
is added to the chainlog and addresses_mainnet.sol
according to the Exec Sheetpocket
is added to the chainlog and addresses_mainnet.sol
according to the Exec SheetDssLitePsmMom
is added to the chainlog and addresses_mainnet.sol
according to the Exec SheetLitePsmJob
is added to the chainlog and addresses_mainnet.sol
according to the Exec Sheetpip
is being added, it is added to the chainlog and addresses_mainnet.sol
as PIP_{TOKEN_SYMBOL}
(i.e. PIP_USDC
)Test coverage:
DssLitePsm
:vow
is set to MCD_VOW
buf
matches the Exec SheetMCD_PAUSE_PROXY
is whitelisted to execute swaps with no fees (i.e. KissLike({LITE_PSM}).bud(MCD_PAUSE_PROXY) == 1
)DssLitePsmMom
is authed (i.e. WardsLike({LITE_PSM}).wards(MOM) == 1
)buyGem
works as expectedsellGem
works as expectedbuyGemNoFee
works as expectedsellGemNoFee
works as expectedDssLitePsmMom
:halt
prevents new swaps in {LITE_PSM}
LitePsmJob
:
CRON_SEQUENCER
(i.e.: SequencerLike(CRON_SEQUENCER).hasJob(LITE_PSM_JOB) == true
)sequencer
matches CRON_SEQUENCER
address from the chainloglitePsm
matches {LITE_PSM}
addressrushThreshold
matches the Exec Sheet (it might be named as "fill threshold")gushThreshold
matches the Exec Sheet (it might be named as "trim threshold")cutThreshold
matches the Exec Sheet (it might be named as "chug threshold")work
has the desired effect:
rush() > _rushThreshold
, fill
is calledcut() > _cutThreshold
, chug
is calledgush() > _gushThreshold
, trim
is called✅ done via test_CRON_LITE_PSM_JOB()
MCD_VAT
:urns[ilk][{LITE_PSM}].ink
is set to the max value that will not cause an overflow (int256(type(uint256).max / RAY)
)MCD_JUG
:duty
) is set to 0% (1 * RAY
) for the ilk (:information_source: covered in config.sol
)MCD_SPOT
:spotter(DST_ILK).mat
is set to 100% (1 * RAY
) (:information_source: covered in config.sol
)spotter(DST_ILK).pip
is set correctlyCHAINLOG
:{x}.{y}.{z+1}
(:information_source: covered in config.sol
)ILK_REGISTRY
:name
matches gem
namesymbol
matches gem
symbolclass
for join-less ilks is used (REG_CLASS = 6
)gem
matches the configured gempip
matches the configured pipgemJoin
is set to address(0)
clip
is set to address(0)
[ ] ilk is removed from AutoLine
[ ] ilk line
is set to 0
[ ] ink
for the PSM is set to 0 on MCD_VAT
after execution, UNLESS there has been a donation
[ ] Global Line
is adjusted accordingly
[ ] ilk is removed from ILK_REGISTRY
[ ] PSM contracts (Psm
, GemJoin
and others, as applicable) are being removed from the chainlog
[ ] Chainlog version is bumped: {x}.{y+1}.0
[ ] PSM contracts (Psm
, GemJoin
and others, as applicable) are being scuttled
MCD_PAUSE_PROXY
is de-authed from all applicable contractsIF collateral offboarding is present in the spell
ilk
) is removed from AutoLine (MCD_IAM_AUTO_LINE
) IF currently enabledvat.ilk.line
) is set to 0
vat.Line
) decreased by the total amount of offboarded ilkschop
) is set to 0
IF requested by governancetip
) is set to 0
IF requested by governancechip
) is set to 0
IF requested by governancehole
) is adjusted via DssExecLib.setIlkMaxLiquidationAmount(ilk, amount)
IF requested by governanceMCD_CLIP_
) is active (i.e. stopped
is 0
)spotter.ilk.mat
) being set very high in the spell (using DssExecLib.setValue(DssExecLib.spotter(), ilk, "mat", ratio)
)DssExecLib.linearInterpolation(name, target, ilk, what, startTime, start, end, duration)
)name
format matches "XXX-X Offboarding"target
matches DssExecLib.spotter()
addressilk
format matches collateral type (ilk
) name ("XXX-X"
)what
matches string "mat"
startTime
matches block.timestamp
start
uses variable CURRENT_XXX_A_MAT
start
matches current spotter.ilk.mat
valueend
uses variable TARGET_XXX_A_MAT
end
value matches the instructionend
allows liquidation of all remaining vaults (end
is bigger than collateral_type_collateralization_ratio * risk_multiplier_factor
)duration
matches the instructionDssExecLib.updateCollateralPrice(ilk)
IF collateral have no running oracle (i.e. relevant PIP_
contract have outdated zzz
value)_checkIlkClipper
helperIF RWA updates are present
doc
is updated_updateDoc
helper is copied one-to-one from the archive and defined above actions
_updateDoc(ilk, doc)
is called in the spellDssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl)
or DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)
vat.ilk.line
) update is requested by the Exec Sheetilk
) have AutoLine
disabled previously or in the spellvat.ilk.line
) is updated, via EITHER:vat.Line
) is updated accordingly, UNLESS specifically instructed not to, via EITHER:global
set to true
in increaseIlkDebtCeiling
/decreaseIlkDebtCeiling
DssExecLib.setGlobalDebtCeiling(amount)
DssExecLib.increaseGlobalDebtCeiling(amount)
DssExecLib.decreaseGlobalDebtCeiling(amount)
~~RwaLiquidationOracleLike(MIP21_LIQUIDATION_ORACLE).bump(ilk, val)
patternbump
explains val
computation via // Note: the formula is: "debt_ceiling * [ (1 + rwa_stability_fee ) ^ (minimum_deal_duration_in_years) ] * liquidation_ratio"
bump
provides locally executable formula (e.g. // bc -l <<< 'scale=18; 50000000 * e(l(1.07) * (3342/365)) * 1.00' | cast --to-wei
)debt_ceiling
in the executable formula matches new debt ceiling set in the spell or the maximum possible debt ceiling in case of the enabled AutoLinerwa_stability_fee
in the executable formula matches stability fee of the specified RWA found on chainminimum_deal_duration_in_years
in the executable formula matches number found in the Exec Sheet of the spell containing relevant RWA onboardingliquidation_ratio
in the executable formula matches liquidation ratio of the specified RWA found on chainval
in the spellval
makes sense in context of the rate mechanismval
calculation is done once per ilk and added to make the total, with separate executable formulas provided in comments. The existing val
value can be retrieved by calling read()
on PIP_RWAXX
and converting the result into decimalDssExecLib.updateCollateralPrice(ilk)
.tell(ilk)
) AND debt ceiling is 0
(OR is being set to 0
in the current spell)RwaLiquidationOracle.tell(ilk)
call is presentRWAXX_A_INPUT_CONDUIT
is an instance of TinlakeMgr
(it is a Centrifuge integration), additional TinlakeMgr.tell()
call is present (in order to prevent further TIN
redemptions in the Centrifuge pool)IF payments are present in the spell
MKR
transfers are presentaddresses_wallets.sol
ether
keywordether
keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred here
testMKRPayments
testtestMKRPayments
matches number in the Exec SheetDAI
surplus buffer transfers are presentaddresses_wallets.sol
testDAIPayments
testtestDAIPayments
matches number in the Exec SheetMKR
or DAI
streams (DssVest
) are createdVestAbstract
interface is imported from dss-interfaces/dss/VestAbstract.sol
restrict
is used for each stream, UNLESS otherwise explicitly stated in the Exec Sheetusr
(Vest recipient address) matches Exec Sheetusr
address in the instruction is in the checksummed formatusr
address variable name match one found in addresses_wallets.sol
tot
(Total stream amount) matches Exec Sheetether
keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred here
bgn
(Vest start timestamp) matches Exec Sheettau
is expressed as bgn - fin
(i.e. MONTH_DD_YYYY - MONTH_DD_YYYY
)fin
(Vest end timestamp) matches Exec Sheeteta
(Vest cliff duration) matches the following logiceta
is explicitly specified in the Exec Sheet, then the values matcheta
and clf
(Cliff end timestamp) are not specified in the Exec Sheet, then eta
is 0
clf
is specified, but clf <= bgn
, then eta
is 0
clf
is specified and clf > bgn
, eta
is expressed as clf - bgn
(i.e. MONTH_DD_YYYY - MONTH_DD_YYYY
)mgr
(Vest manager address) is specified in the Exec Sheet, matches the value, OTHERWISE matches address(0)
cap
) is enough for the new streamstot
divided by tau
) <=
the maximum vest streaming rate (cap
)tot
divided by tau
) >
the maximum vest streaming rate (cap
)cap
value equal to 10% greater than the new maximum vesting rate, then round new cap
up with 2 significant figure precision (i.e. 2446 becomes 2500)cap
) is changed in the spelltotal
(the sum of all tot
values)testVestDAI
or testVestMKR
MKR
or DAI
vest termination (Yank
) is presentMCD_VEST_MKR_TREASURY
chainlog address is used for MKR stream yank
MCD_VEST_DAI
chainlog address is used for DAI stream yank
testYankDAI
or testYankMKR
IF SubDAO-related content is present
ProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));
addresses_deployers.sol
as an entryDelegateCall
context)vat
, etc. (Check comprehensively where the risk is high)PAUSE_PROXY
as their admin
(i.e. the party that can upgrade)admin
that is not PAUSE_PROXY
are not authed on any core contracts (Blocking)IF external contracts calls are present (Not SubDAOs, e.g. Starknet)
delegatecall
CREATE2
(e.g. if it looks like a vanity address) do not have selfdestruct
in their codeIF spell interacts with ChainLog
addresses_mainnet.sol
testChainlogIntegrity
and testChainlogValues
[x] Ensure every spell variable is declared as public
/internal
[x] Ensure immutable
visibility is only used when fetching addresses from the ChainLog
via DssExecLib.getChangelogAddress(key)
and constant
is used instead for static addresses
address
and wrap with Like
suffix interfaces inline (when making calls), UNLESS archive patterns permit otherwise (Such as MKR
)DssExecLib.vat()
)ChainLog
, the variable name must match the value of the ChainLog key for that address (e.g. MCD_VAT
rather than vat
), except where the archive pattern differs from this pattern (e.g. MKR)Tests
DssExecLib.address
file is not being modified by the spell PRpublic
skipped
modifier; OTHERWISE, it MUST have the skipped
modifiertestRwaConduitsPsmUpdate()
[x] Phase 2 USDC Migration from PSM-USDC-A to LITE-PSM-USDC-A
[x] Update PSM-USDC-A Fees
[x] Update PSM-USDC-A DC-IAM
[x] Update MCD_LITE_PSM_USDC_A Buf
[x] Update LITE-PSM-USDC-A DC-IAM
✅ test_LITE_PSM_USDC_A_MigrationPhase2()
, testLitePSMs
& testGeneral()
and editing config.sol
properly
[x] GSM Delay Update
✅ testGeneral()
and editing config.sol
properly
[x] Update LitePSM Keeper Network Job & Bump chainlog version
✅ test_CRON_LITE_PSM_JOB()
& testChainlogIntegrity()
& testChainlogValues()
printenv | grep "FOUNDRY_\|DAPP_"
)make test
[PASS]
prefix._Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠰] Compiling 4 files with Solc 0.8.16
[⠔] Solc 0.8.16 finished in 1.37s
Compiler run successful!
Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1660987)
[PASS] testStarknetSpell() (gas: 2324)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 36.14s (30.39s CPU time)
Ran 37 tests for src/DssSpell.t.sol:DssSpellTest
[SKIP] testBytecodeMatches() (gas: 0)
[PASS] testCastCost() (gas: 1518163)
[PASS] testCastOnTime() (gas: 1515037)
[PASS] testChainlogIntegrity() (gas: 6064192)
[PASS] testChainlogValues() (gas: 9989239)
[SKIP] testCollateralIntegrations() (gas: 0)
[PASS] testContractSize() (gas: 11184)
[SKIP] testDAIPayments() (gas: 0)
[SKIP] testDaoResolutions() (gas: 0)
[PASS] testDeployCost() (gas: 4623035)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 30353820)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 2441054)
[SKIP] testMKRPayments() (gas: 0)
[SKIP] testMedianizers() (gas: 0)
[SKIP] testNewIlkRegistryValues() (gas: 0)
[PASS] testNextCastTime() (gas: 446546)
[SKIP] testOSMs() (gas: 0)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 495577)
[SKIP] testOracleList() (gas: 0)
[PASS] testPSMs() (gas: 2823438)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17507)
[PASS] testRwaConduitsPsmUpdate() (gas: 1586063)
[SKIP] testSparkSpellIsExecuted() (gas: 0)
[PASS] testUseEta() (gas: 352730)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
[PASS] test_CRON_LITE_PSM_JOB() (gas: 2694693)
[PASS] test_LITE_PSM_USDC_A_MigrationPhase2() (gas: 1588144)
Suite result: ok. 16 passed; 0 failed; 21 skipped; finished in 401.01s (942.76s CPU time)
Ran 2 test suites in 401.95s (437.15s CPU time): 18 tests passed, 0 failed, 21 skipped (39 total tests)
Exec Doc checks
[x] Exec Doc for the specified date is found in the makerdao/community
GitHub repo
[x] Exec Doc file name follows the format Executive vote - Month DD, YYYY.md
[x] Extract permanent URL to the raw markdown file and paste it below Insert your Raw Exec Doc URL here https://raw.githubusercontent.com/makerdao/community/8d95eaf1c9eb6722008172504df88bc27f91ed3c/governance/votes/Executive%20vote%20-%20August%2022%2C%202024.md
[ ] Using Exec Doc URL from the above and the TARGET_DATE
, generate Exec Doc Hash via make exec-hash date=$TARGET_DATE $URL
ℹ️ The script is not working locally
Insert your Exec Doc Hash here
[x] Using Exec Doc URL from the above, generate Exec Doc Hash via cast keccak -- "$(curl '$URL' -o - 2>/dev/null)"
Insert your Exec Doc Hash here
0xe3794c8152d2a1de72080b1fc7d8429a979015b3f41cbe2c26f755724c70951d
[x] Make sure that hash above doesn't match keccak
hash of the empty string (0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470
)
[x] Using Exec Doc URL from the above, read spell instructions from the Exec Doc and list them below List all instructions announced in the Exec Doc
Update PSM State Variables in Conduit Contracts
The PSM state variables in the following conduit contracts will be updated to point to MCD_LITE_PSM_USDC_A:
Migrate Reserves from PSM-USDC-A to LITE-PSM-USDC-A
Update PSM-USDC-A Fees The PSM-USDC-A fees will be updated as follows:
Update PSM-USDC-A DC-IAM Parameters
The PSM-USDC-A DC-IAM parameters below will be updated as follows:
Update MCD_LITE_PSM_USDC_A buf
The MCD_LITE_PSM_USDC_A fixed-sized amount of pre-minted Dai (buf) will be increased as follows:
Update LITE-PSM-USDC-A DC-IAM Parameters
The LITE-PSM-USDC-A DC-IAM will be updated as follows:
Update GSM Delay
the GSM Pause Delay will be updated as follows:
Update LitePSM Keeper Network Job
The LitePSM Keeper Network Job will be updated with the following contract calls and parameters, as a consequence of the LITE-PSM-USDC-A DC-IAM and buf parameter changes described earlier in this document:
[x] Office hours value in the Exec Doc matches the spell
[ ] Sum of all payments in the Exec Doc matches the tests
[x] Exec Doc URL in the spell comment matches your Raw Exec Doc URL above
[x] Exec Doc URL in the spell comment refers to the https://github.com/makerdao/community repository
[x] Every action present in the spell code is present in the Exec Doc
[x] Every action in the Exec Doc is present in the spell code
Spell deployed
Spell address: 0x969c91C5aC11D4d1077A6aAF3d2BA617906543Cc Tenderly testnet: https://dashboard.tenderly.co/explorer/vnet/1d03288b-c368-4275-bd1f-2cdc16c4c143
TLDR: Good to handover
false
UNLESS the contract size is too big AND all mitigation strategies (i.e.: removing revert strings) have failedmake diff-deployed-spell
or manually)make check-deployed-spell
GNU GPLv3
) and visible in the verified code (AGPL-3.0-or-later
) matches licence found in the spell itselfDssExecLib.address
filedeployed_spell_created
matches deployment timestampdeployed_spell_block
matches deployment block numbermake deploy-info tx=<tx>
matches config
deployed_spell_created
timestampdeployed_spell_block
block numberDssExecLib.address
file (e.g. look under the 'Files Changed' PR tab, etc.)Libraries Used
matches DssExecLib Latest Releasec0d3c6c
made on Feb 1, 2022, while git submodule lib/dss-exec-lib
is set to track the latest commit 69b658f
made on Jan 23, 2023. Here is the diff between the latest release and the submodule: https://github.com/makerdao/dss-exec-lib/compare/v0.0.9...69b658f35d8618272cd139dfc18c5713caf6b96b#diff-72201ff20380f5c7fc89281be3ad2dd6bd5a992f246d41d6d9d97f71e078d40d. The only major difference between deployed and the imported library is the new setRWAIlkDebtCeiling
, which we're not using in this particular spellmake diff-archive-spell
for current date or make diff-archive-spell date="YYYY-MM-DD"
DssExecLib.address
file is not being modified by the spell PRprintenv | grep "FOUNDRY_\|DAPP_"
)make test
_Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠔] Compiling 4 files with Solc 0.8.16
[⠒] Solc 0.8.16 finished in 2.47s
Compiler run successful!
Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1660987)
[PASS] testStarknetSpell() (gas: 2324)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 37.33s (34.37s CPU time)
Ran 37 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testBytecodeMatches() (gas: 4643839)
[PASS] testCastCost() (gas: 1518163)
[PASS] testCastOnTime() (gas: 1515037)
[PASS] testChainlogIntegrity() (gas: 6064192)
[PASS] testChainlogValues() (gas: 9989239)
[SKIP] testCollateralIntegrations() (gas: 0)
[SKIP] testContractSize() (gas: 0)
[SKIP] testDAIPayments() (gas: 0)
[SKIP] testDaoResolutions() (gas: 0)
[SKIP] testDeployCost() (gas: 0)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 30355917)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 2441054)
[SKIP] testMKRPayments() (gas: 0)
[SKIP] testMedianizers() (gas: 0)
[SKIP] testNewIlkRegistryValues() (gas: 0)
[PASS] testNextCastTime() (gas: 446546)
[SKIP] testOSMs() (gas: 0)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 495577)
[SKIP] testOracleList() (gas: 0)
[PASS] testPSMs() (gas: 2823438)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17507)
[PASS] testRwaConduitsPsmUpdate() (gas: 1586063)
[SKIP] testSparkSpellIsExecuted() (gas: 0)
[PASS] testUseEta() (gas: 352730)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
[PASS] test_CRON_LITE_PSM_JOB() (gas: 2687681)
[PASS] test_LITE_PSM_USDC_A_MigrationPhase2() (gas: 1588144)
Suite result: ok. 15 passed; 0 failed; 22 skipped; finished in 396.88s (850.85s CPU time)
Ran 2 test suites in 397.65s (434.21s CPU time): 17 tests passed, 0 failed, 22 skipped (39 total tests)
testBytecodeMatches
passdelegatecall
code inside verified codeselfdestruct
code present in the deployed codefalse
UNLESS the contract size is too big AND all mitigation strategies (i.e.: removing revert strings) have failedmake diff-deployed-spell
or manually)
ℹ️ Checked manually as the addition of libraries makes the script report mismatches!make check-deployed-spell
DssExecLib.address
filedeployed_spell_created
matches deployment timestampdeployed_spell_block
matches deployment block numbermake deploy-info tx=<tx>
matches config
deployed_spell_created
timestamp
ℹ️ timestamp: 1724332103deployed_spell_block
block number
ℹ️ block: 20584345DssExecLib.address
file (e.g. look under the 'Files Changed' PR tab, etc.)Libraries Used
matches DssExecLib Latest Releasemake diff-archive-spell
for current date or make diff-archive-spell date="YYYY-MM-DD"
DssExecLib.address
file is not being modified by the spell PRprintenv | grep "FOUNDRY_\|DAPP_"
)make test
_Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠰] Compiling 4 files with Solc 0.8.16
[⠔] Solc 0.8.16 finished in 1.39s
Compiler run successful!
Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1660987)
[PASS] testStarknetSpell() (gas: 2324)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 40.01s (35.83s CPU time)
Ran 37 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testBytecodeMatches() (gas: 4643839)
[PASS] testCastCost() (gas: 1518163)
[PASS] testCastOnTime() (gas: 1515037)
[PASS] testChainlogIntegrity() (gas: 6064192)
[PASS] testChainlogValues() (gas: 9989239)
[SKIP] testCollateralIntegrations() (gas: 0)
[SKIP] testContractSize() (gas: 0)
[SKIP] testDAIPayments() (gas: 0)
[SKIP] testDaoResolutions() (gas: 0)
[SKIP] testDeployCost() (gas: 0)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 30355917)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 2441054)
[SKIP] testMKRPayments() (gas: 0)
[SKIP] testMedianizers() (gas: 0)
[SKIP] testNewIlkRegistryValues() (gas: 0)
[PASS] testNextCastTime() (gas: 446546)
[SKIP] testOSMs() (gas: 0)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 495577)
[SKIP] testOracleList() (gas: 0)
[PASS] testPSMs() (gas: 2823438)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17507)
[PASS] testRwaConduitsPsmUpdate() (gas: 1586063)
[SKIP] testSparkSpellIsExecuted() (gas: 0)
[PASS] testUseEta() (gas: 352730)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
[PASS] test_CRON_LITE_PSM_JOB() (gas: 2687681)
[PASS] test_LITE_PSM_USDC_A_MigrationPhase2() (gas: 1588144)
Suite result: ok. 15 passed; 0 failed; 22 skipped; finished in 469.21s (1097.08s CPU time)
Ran 2 test suites in 469.86s (509.22s CPU time): 17 tests passed, 0 failed, 22 skipped (39 total tests)
new-spells
is correctnew-spells
channel (via a separate "reply to" message, restating the address to avoid edits)
new-spells
Description
Contribution Checklist
(PE-<TICKET_NUMBER>)
Checklist
officeHours
modifier override30 days
unless otherwise specified)ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
mainnet
contract on etherscanmake archive-spell
ormake date="YYYY-MM-DD" archive-spell
to make an archive directory and copyDssSpell.sol
,DssSpell.t.sol
,DssSpell.t.base.sol
, andDssSpellCollateralOnboarding.sol
squash and merge
this PR