Fix make exec-hash script - Githubissues

makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

122 stars 50 forks source link

Fix make exec-hash script #425

Closed SidestreamColdMelon closed 2 months ago

SidestreamColdMelon commented 2 months ago

Goal

exec-hash script is working or related check from the reviewer checklist is removed

Context

Running script currently returns error on mac

date: illegal option -- d
usage: date [-jnRu] [-I[date|hours|minutes|seconds]] [-f input_fmt]
        [-r filename|seconds] [-v[+|-]val[y|m|w|d|H|M|S]]
        [[[[mm]dd]HH]MM[[cc]yy][.SS] | new_date] [+output_fmt]

Additional problem is inconsistent exec-doc name
- Executive Vote in exec doc name will make the script fail (Error: Executive vote not found) as the script was develop to work with Executive vote

Potential solutions

Rewrite script from shell to another language (eg python)
Simplify script (eg do not try to find exec doc in the repo)
Remove script and relevant checklist