search

makinacorpus / django-leaflet

Use Leaflet in your Django projects
GNU Lesser General Public License v3.0
716 stars 282 forks source link

Make 'LeafletWidget._get_attrs' a public method #326

Closed 3j14 closed 3 years ago

3j14 commented 3 years ago

This will deprecate LeafletWidget._get_attrs in favor of LeafletWidget.get_attrs for the use in e.g. django.forms.MultiWidget.

The issue of _get_attrs has been discussed in #322 and should be resolved by this.

3j14 commented 3 years ago

As seen in 9c62b18, I added an additional test. I was unsure whether this is the right test class. Let me know if the test should be put into an additional class.

Besides that, I ran all tests without a failure.

Gagaro commented 3 years ago

Thanks for the PR, I'll fix the linting and release it afterward.

3j14 commented 3 years ago

Thanks for merging!

Gagaro commented 3 years ago

Released in 0.28.1