search

makseo / ng2-sticky

Angular 2+ solution to make elements stick during scrolling.
https://domainlines.com
MIT License
92 stars 50 forks source link

"left" attribute needs to be recalculated if the viewport's width changes #12

Closed PAStheLoD closed 7 years ago

PAStheLoD commented 7 years ago

Hello,

First of all thank you for this nice component!

So, it looks like that resizing the browser (let's say the user rotates their mobile to landscape, or uses an old school desktop computer, or otherwise the window.innerWidth changes) results in an incorrect "left" attribute.

Are there plans to handle this problem?

MehdiSaeedifar commented 7 years ago

any progress?

ImTheC commented 7 years ago

The fix has been submitted here: https://github.com/makseo/ng2-sticky/pull/20

Just waiting for it to be merged.

In the meantime, if you can, you could manually edit the code based on the pull request.

FriOne commented 7 years ago

@makseo Guess this was not published to npm.

makseo commented 7 years ago

@FriOne, try to use the latest version (4.0.1) PR from @ImTheC has to be in this release version.