search

maksimhorowitz / nflscrapR

R Package for Scraping and Aggregating NFL Data
532 stars 139 forks source link

Yards.Gained not accurate with laterals #95

Closed bishop22 closed 6 years ago

bishop22 commented 6 years ago

As an example, for GameID 2018091606 and play_id 4196, Yards.Gained = 7, but statistically it was -5. Here is the desc: (:03) (Shotgun) N.Foles pass short right to Z.Ertz to PHI 28 for 7 yards. Lateral to N.Agholor to PHI 21 for -7 yards. Lateral to N.Foles to PHI 15 for -6 yards. Lateral to W.Smallwood to PHI 19 for 4 yards. FUMBLES, RECOVERED by TB-L.David at PHI 16.

In the official NFL stats, N.Foles was given -5 passing yards. It would be nice to have the ability to match the NFL passing stats for the season, using information in the data frame that is returned. Of course there will be similar issues with receiving yards, which might be tough to tackle at an individual player level, given an arbitrary number of players could receive a lateral and gain/lose receiving yards.

ryurko commented 6 years ago

Thanks for noticing this, but the original game_play_by_play function is no longer supported. Please use the scrape_json_play_by_play and scrape_season_play_by_play instead.

bishop22 commented 6 years ago

Thanks for the help. I didn't have visibility to those functions' existence when I installed, but I see the code now.

On Thu, Oct 18, 2018, 6:04 PM Ron Yurko notifications@github.com wrote:

Closed #95 https://github.com/maksimhorowitz/nflscrapR/issues/95.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maksimhorowitz/nflscrapR/issues/95#event-1913472101, or mute the thread https://github.com/notifications/unsubscribe-auth/ASTRjy5P_Yo7a6lBUd6iDMP4QzjhMnt7ks5umPsEgaJpZM4XvTR_ .