makson96 / Dynamics

Dynamics PyMOL Plugin
GNU General Public License v3.0
40 stars 16 forks source link

PyMOL-2.5.0a0/Gromacs / TK Error #99

Closed spmolnar closed 4 years ago

spmolnar commented 4 years ago

I am running PyMOL-2-5-0a0 on my Debian Buster platform and have encountered an error. Gromacs 2019.9 and Dynamics-master plugin.

Error: 1 TypeError Exception in Tk callback Function: <function Misc.after..callit at 0x7f3a07c35bf8> (type: <class 'function'>) Args: () Traceback (innermost last): File "/usr/local/lib/python3.7/dist-packages/Pmw.py", line 1823, in call return self.func(args) File "/usr/lib/python3.7/tkinter/init.py", line 749, in callit func(args) File "/home/comp/.pymol/startup/pymol_plugin_dynamics.py", line 1580, in bar_display showInterpretationWindow() File "/home/comp/.pymol/startup/pymol_plugin_dynamics.py", line 1818, in showInterpretationWindow interpretation() TypeError: 'InterpretationWindow' object is not callable

speleo3 commented 4 years ago

Looks like the InterpretationWindow object was never callable. The error is silently suppressed in Python 2 (AttributeError), but in Python 3 this raises a TypeError which is not suppressed by the plugin. The entire try/except block should just be removed.

https://github.com/makson96/Dynamics/blob/3918691cd5c6f3b4f0b85a85e3a1e2600edd8652/pymol_plugin_dynamics.py#L1817-L1820

spmolnar commented 4 years ago

Again, Thanks, Thomas

     Steve

On 08/05/2020 04:25 AM, Thomas Holder wrote:

Looks like the |InterpretationWindow| object was never callable. The error is silently suppressed in Python 2 (|AttributeError|), but in Python 3 this raises a |TypeError| which is not suppressed by the plugin. The entire try/except block should just be removed.

https://github.com/makson96/Dynamics/blob/3918691cd5c6f3b4f0b85a85e3a1e2600edd8652/pymol_plugin_dynamics.py#L1817-L1820

??? You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/makson96/Dynamics/issues/99#issuecomment-669056601, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYRMISWSO75ZHQ2BNG63XLR7EJN3ANCNFSM4O2UGMAA.

-- Stephen P. Molnar, Ph.D. www.molecular-modeling.net 614.312.7528 (c) Skype: smolnar1

makson96 commented 4 years ago

Thank you very much for the report. Patch is applied in main code: https://github.com/makson96/Dynamics/commit/4ef2113678fa42b80d2d3acf4529840b8ee2fd92