note reorg - Githubissues

malariagen / fits

File tracking system for group DK

0 stars 0 forks source link

note reorg #59

Closed magnusmanske closed 5 years ago

magnusmanske commented 5 years ago

This:

Adds the SQL schema to create a new FITS DB instance, including the current tags
Implements a Note class to use with the note table/note_id fields for improved note management in FITS (separation of source, rationale, and date) Successfully tested on production FITS and import-from-scratch FITS copy.

magnusmanske commented 5 years ago

I know it was the holidays, but I'm back at work, so approving this myself.

alimanfoo commented 5 years ago

Thanks @magnusmanske for putting this in a PR, very helpful. Very useful to have the schema source code here.

So you don't get blocked by slow reviews in future, I'd suggest you could just adopt a "merging soon if no comments" approach. I.e., please feel free to request a review from me and/or @podpearson, but if no-one comments within say 24 hours, feel free to merge.

magnusmanske commented 5 years ago

@alimanfoo Thanks, that seems like a reasonable approach, especially since this is more about keeping people up-to-date than detailed code review.