malcolmang / pe

0 stars 0 forks source link

String arguments for `Add-expense` do not allow dashes in the beginning #3

Open malcolmang opened 1 year ago

malcolmang commented 1 year ago

image.png

As seen above, the Add-Expense command does not allow users to enter strings that begin with - and follow up with text.

This produces an error but the User Guide gives no indication that this isn't allowed. This is true of all the arguments that accept text strings.

nus-pe-bot commented 1 year ago

Team's Response

Greetings malcolmang,

Thank you for your bug report. After careful evaluation of your bug report, the development team is rejecting this bug report due to the following reasons:

1) The user guide states the limitation on adding hyphens:

image.png

Regards, xzynos

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The limitations here say "argument values cannot be the same as argument options".

However, "-test" is not the same as any argument - only that it is prefixed by the argument-t`.

This is a minor but important difference: "hello" and "he" are not the same, but "hello" contains "he". This is not behaviour explained in documentation.

In this case, not allowing any string that begins with "-t" or "-p" is unnecessary limiting: if a user would like to enter a description beginning with a dash that happens to have t afterward, the program doesn't support this and also doesn't provide clear documentation as to why. Thus, I would still classify this as a minor, low severity bug.