malcolmang / pe

0 stars 0 forks source link

Commands that should take no arguments still accept arguments #6

Open malcolmang opened 1 year ago

malcolmang commented 1 year ago

image.png As seen above. This may confuse users as this is behaviour not defined by the User Guide.

nus-se-script commented 1 year ago

Team's Response

Greetings malcolmang,

Thank you for your bug report. After careful evaluation of your bug report, the development team is rejecting this bug report due to the following reasons:

1) The parsing of commands is handled by the Apache Commons CLI library. This library allows for duplicate arguments as certain applications require the passing of multiple values for the same argument (E.g. Command -a arg1 -a arg2 -a arg3). In our case, the application takes in the first valid argument and the rest will be ignored.

2) The user guide clearly states that "The presence of invalid or extra arguments will be ignored by MoneyGoWhere." under the section "Understanding the Command Syntax".

image.png

Regards, xzynos

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Invalid commands have been accepted by the system

Screenshot 2022-11-11 at 5.13.45 PM.png

As seen above, when trying to edit expense at index 4, multiple -e flags have been accepted by the system, and even provides an output saying that 'The expense was edited succesfully', even though no edit can virtually be observed for expense at index 4.

The system should have better input validation to check these kind of cases such as multiple of the same flag, as a user may unintentionally key in such inputs. Expected output should be for instance - invalid arguments entered


[original: nus-cs2113-AY2223S1/pe-interim#817] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Greetings karthikstar,

Thank you for your bug report. After careful evaluation of your bug report, the development team is rejecting this bug report due to the following reasons:

1) The parsing of commands is handled by the Apache Commons CLI library. This library allows for duplicate arguments as certain applications require the passing of multiple values for the same argument (E.g. Command -a arg1 -a arg2 -a arg3). In our case, the application takes in the first valid argument and the rest will be ignored.

2) The user guide clearly states that "The presence of invalid or extra arguments will be ignored by MoneyGoWhere." under the section "Understanding the Command Syntax".

image.png

Regards, xzynos

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]