Relative date formatter concurrency issue

malcommac / SwiftDate

🐔 Toolkit to parse, validate, manipulate, compare and display dates, time & timezones in Swift.

MIT License

7.64k stars 770 forks source link

Relative date formatter concurrency issue #738

Closed rkreutz-teamwork closed 4 years ago

rkreutz-teamwork commented 4 years ago

Hey there,

So we were having some concurrency issues related to to that write on the cachedValues dictionary. I was about to make that property atomic/thread safe, but it seems values are being set but never read, so I guess it doesn't make sense to have that dictionary there anymore.

Cheers

malcommac commented 4 years ago

fixed in https://github.com/malcommac/SwiftDate/commit/9e98fe92df2085800604caeee559d01e88a2417c and started using cache. thanks