search

malsup / cycle2

2nd gen cycling
899 stars 239 forks source link

issues with latest wordpress update #851

Open EileenWeb opened 3 years ago

EileenWeb commented 3 years ago

Hi,

There appears to be an issue with cycle2 and the latest wordpress update. I don't know if anyone else is having the same problem? We have been told that cycle2 would need to be upgraded (custom code in place on website). Is this necessary to upgrade? Happy to share the site that has cycle2, privately.

Thanks, Eileen.

EileenWeb commented 3 years ago

Anyone from Cycle2 able to answer this?

iam-sysop commented 3 years ago

Most likely you have issue from jQuery changes that have affected Cycle2.

jQuery 3 had breaking changes that affect Cycle2 operation.

Some forks (including one I maintain) have fixes to support Cycle2 with newer jQuery versions (3.x +).

**NOTE: Personally I do not support WordPress in any fashion - the updated files on my fork MAY help someone with experience updating "parts" of a wordpress site or plugin manually.

Fork here: https://github.com/thecarnie/cycle2

iam-sysop commented 3 years ago

I have updated my branch with changes as noted. Fixes include updates to support jQuery 3.x+ in the installation.

https://github.com/thecarnie/cycle2/releases/tag/2.1.6b

Testing and verification IS REQUIRED before putting into production.

webimagedesigns commented 3 years ago

jQuery.type and jQuery.isFunction() are being flagged as deprecated by jQuery Migrate in WordPress 5.6 for jquery.cycle2.min.js. I am using jQuery.cycle2.min.js /*!

iam-sysop commented 3 years ago

Thank you - I will investigate and push updates!

webimagedesigns commented 3 years ago

Thank you! Will you post in the issue so I will know when the new code is pushed?

On Thu, Jan 21, 2021, 10:47 PM sysop notifications@github.com wrote:

Thank you - I will investigate and push updates!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/malsup/cycle2/issues/851#issuecomment-765101562, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFHBUDDPQGDX4YOESDVRA3S3DYN3ANCNFSM4QKFPNQQ .

iam-sysop commented 3 years ago

An updated release with noted changes has been published downstream on my fork of cycle2.

Multiple fixes, patches, cleanups, and updates throughout.

See https://github.com/thecarnie/cycle2/master for details and commit history.

Brings current with all patches found and applied either in this repo or downstream in mine. I will assemble proper upstream pull request next for inclusion here.

Release bundle available at my fork here:

https://github.com/thecarnie/cycle2/releases/tag/2.1.6c