search

mamba-org / mamba

The Fast Cross-Platform Package Manager
https://mamba.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6.97k stars 359 forks source link

Investigate rstrip UB #3493

Closed JohanMabille closed 1 month ago

JohanMabille commented 2 months ago

https://github.com/mamba-org/mamba/pull/3488 introduced a new implementation of rstrip because that in util/string.cpp has undefined behavior in that case. This should be investigated and fixed.

JohanMabille commented 1 month ago

There is actually no UB in rstrip, it's a misusage of the algorithm.