The expectaction of this change is that the intent was to remove elements (env vars values) from that vector, in which case an erase was missing as remove_if will not remove elements, just move them around and report where the new range ends (c++20's std::erase_if would have done the job more properly here - or replacing the container by a flat_map).
The expectaction of this change is that the intent was to remove elements (env vars values) from that vector, in which case an
erasewas missing asremove_ifwill not remove elements, just move them around and report where the new range ends (c++20'sstd::erase_ifwould have done the job more properly here - or replacing the container by a flat_map).