coveralls
commented
2 months ago Pull Request Test Coverage Report for Build 10086318472
Details
- 4 of 9 (44.44%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.5%) to 58.616%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/activations/activateTerminal.ts | 0 | 5 | 0.0% | ||
| <!-- | Total: | 4 | 9 | 44.44% | --> |
| Totals | |
|---|---|
| Change from base Build 9595185128: | 0.5% |
| Covered Lines: | 397 |
| Relevant Lines: | 620 |
new EnvironmentVariableCollection API introduced in https://github.com/microsoft/vscode/issues/179476 allows to (re)apply environment variables at the shell integration stage. This is crucial for macOS which uses login shell as default and overrides or prepends set PATH on startup, leading to micromamba paths being absent or push towards the end. This results in system binaries being used as default, essentially deactivating the conda environment
Update
@types/vscodeand@vscode/test-electronto the latest versions to allow use of the new APIPass in EnvironmentVariableMutatorOptions{ applyAtProcessCreation: true, applyAtShellIntegration: true } to guarantee PATH and other environment variables reapplication after default shell initializtion is complete
Add filtering of the standard shell and vscode environment variables in
parseMicromambaShellActivateResponsein order to avoid attempting to change read-only variables like PWD and SHLVL as well as causing potential side effects with process specific variables like VSCODE_ (see in code comments for more details)