mamedev / mame

MAME
https://www.mamedev.org/
Other
8.02k stars 1.99k forks source link

MAME 0.223 vgmplay.xml missing platform names #7117

Closed ghost closed 4 years ago

ghost commented 4 years ago

Hi

Can the maintainer of vgmplay.xml please add the missing platform names inside the vgmplay.xml file for following games?

Normally a game has between (...) a platform name like (NES), (Arcade), (SMS), ...

but I found many games having NO platform at all but something else between (...). Either the platform name must be added at the end in a separate (...) or the current string between (...) can be replaced by the platform name.

Here are the strings between (...) inside the game names of vgmplay.xml that have no platform name:

1943 air buster asuka & asuka blockout break thru bubble bobble cosmo police galivan double dragon frogger ghosts'N goblins hang-on hudson karnov lock'n'chase mexico 86 mitchell mystic warriors nichibutsu crazy climber ninja gaiden parodius psikyo rainbow islands rastan saga side arms sunset riders super qix terra cresta the combatribes the new zealand story thunder cross

Thx in advance

Tafoid commented 4 years ago

All the titles mentioned above are ARCADE titles or drivers. All shortnames in the vgmplay.xml list NOT containing an underscore with a suffix (example: aburner2_md = Megadrive) is assumed to be an ARCADE title (example: aburner2 = Arcade). The seemingly duplicated names you see are referencing the actual MAME drivers and those titles were imported 100% from the actual vgmrips package name and documentations. A lot of effort was made to retain as much data vgmrips has provided as to not allow any confusion as to what was added. Also, current source has all titles with a (..) with something denoting driver, platform, etc. per your last request #7092 which I honored when adding the most recent vgmrips package released. https://github.com/mamedev/mame/commit/ce89e1d1a709fc8206309ea28aaa65375cb03932

I'm not exactly sure what you want now. If you want to work with vgmrips.info to have them fix up the package names, categories, and such to match your requests, you are welcome to do so. As far as vgmrips.xml MAME documentation is concerned this all isn't an issue as I see it.

ghost commented 4 years ago

Hi

Ok, after reading this I have another question.

Why do some arcade games have "(Arcade)" in the game name while others (see my list) don't? You say it are all arcade games, but why is "(Arcade)" added in some game names and not at all in others? Either add it everywhere, add it nowhere but don't add it somewhere IMHO :-)

Examples (first has (Arcade); second has nothing):

<software name="aerofgt">
        <description>Aero Fighters (Arcade)</description>
        <year>1992</year>
        <publisher>Mc O'River, Inc. (U) / Tecmo, Ltd. (J)</publisher>
<software name="airbustr">
        <description>Air Buster (Air Buster)</description>
        <year>1990</year>
        <publisher>Namco</publisher>
ghost commented 4 years ago

I was also wondering: maybe it would be nice to add a new XML tag which indicates from which platform the game comes? In this way vgmplay driver can also read the game platform from the XML file and display it somewhere on the screen (like the sound chips now). I think that's missing a bit now. In this way the platform can also be removed from the game name.

Examples (first uses "arcade" to indicate it's from MAME's main game list, second uses the software list name of the game):

<software name="aerofgt">
        <description>Aero Fighters</description>
        <year>1992</year>
        <publisher>Mc O'River, Inc. (U) / Tecmo, Ltd. (J)</publisher>
                <platform>arcade<platform>
<software name="1942_nes">
        <description>1942</description>
        <year>1985</year>
        <publisher>Capcom</publisher>
                <platform>nes<platform>
ghost commented 4 years ago

I personally would like to have the platform name in the vgmplay window too. We only see the sound chips now.

The currently playing song name would be nice too. I think vgm/vgz files have metadata, AFAIR the metadata is displayed in zxtune chiptunes player.

MooglyGuy commented 4 years ago

Don't bullshit us. You're clearly just "jessicajonesunitedkingdom" re-registered under a different nickname.

image