Implement Ipc Client - Githubissues

ayrat555 commented 7 years ago

Implement Ipc Client like HttpClient is implemented (with Ethereumex.Client.Macro)

defmodule Ethereumex.IpcClient do
  use Ethereumex.Client.Macro

  def request(payload) do
    // request with Unix socket
  end
end

Currently there is no decent adapter for Unix sockets in Elixir ecosystem. I think we should try to use procket but its api is too ugly and low level.

After finishing ipcClient HttpClient in SmartContract modules should be replaced with the new client.

NickPapacostas commented 7 years ago

@ayrat555 I'm interested in working on this, were you thinking of using something like procket to communicate with the socket?

thanks for all your work!

ayrat555 commented 6 years ago

@NickPapacostas I'm sorry for a late answer. Yes, I thought about using procket. But as I wrote earlier its interface is very ugly. I'll try to dig into it in my spare time. Btw PRs are welcome

plu9in commented 6 years ago

@ayrat555 @NickPapacostas Is it not possible to use https://stackoverflow.com/questions/1478831/erlang-unix-domain-socket-support ?

ayrat555 commented 6 years ago

@plu9in Yes, it's possible.

@NickPapacostas wanted to work on this

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.4 ETH (199.06 USD @ $497.65/ETH) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$24,798.60 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 6 years ago

@raininja Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] warning (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

spm32 commented 6 years ago

Hi @NickPapacostas, did you still want to work on this?

raininja commented 6 years ago

I'm working on it. I will be happy to let it go if there was someone else more interested, or has started work on it.

raininja commented 6 years ago

I've decided to implement shackle for the IPC Client. I am wondering if it would not be prudent to also upgrade(?) the httpclient at the same time? Or is this approach too heavy? @ayrat555

ayrat555 commented 6 years ago

why httpclient should be upgraded?
does shackle support unix sockets?

raininja commented 6 years ago

@ayrat555 I was thinking that httpclient would need to be upgraded to sync the two "backends" and yes, shackle does support unix sockets If you check jsonrpc-elixir as a reference, they've used shackle and buoy to this effect.

If you think this approach is to heavy/invasive, I can simply use gen_rpc for this

ayrat555 commented 6 years ago

Let's use gen_rpc. Thanks

gitcoinbot commented 6 years ago

@raininja Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] warning (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@raininja due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

[x] warning (3 days)
[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

vs77bb commented 6 years ago

Hi @raininja are you still working on this one? Hope you are doing well 🙂

raininja commented 6 years ago

@vs77bb yes I am! All the best!

raininja commented 6 years ago

Why have I gotten an email saying I was removed from this bounty?

spm32 commented 6 years ago

Sorry @raininja that's just an automated message from gitcoinbot, you're still on the issue, snoozing the bot now.

mkosowsk commented 6 years ago

@raininja how's your cornea? :) Think you'll be able to take a look at this issue? Thanks!

raininja commented 6 years ago

@mkosowsk I'm ok, thanks. I'm actually working on this now, having a bit of an issue as the documentation for the go-ethereum client days one thing but the geth console says another, the APIs don't seem to match

raininja commented 6 years ago

@mkosowsk I'm ok, thanks. I'm actually working on this now, having a bit of an issue as the documentation for the go-ethereum client days one thing but the geth console says another, the APIs don't seem to match

mkosowsk commented 6 years ago

@ayrat555 do you have any insight on @raininja's issue on why the API's don't seem to match? Thanks!

ayrat555 commented 6 years ago

Maybe geth's API includes custom methods or methods in the library is out of date

gitcoinbot commented 6 years ago

@raininja Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] warning (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@raininja due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

[x] warning (3 days)
[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

raininja commented 6 years ago

Still working on this, recently submitted a WIP PR

raininja commented 6 years ago

still plugging away, awaiting some feedback from @ayrat555

raininja commented 6 years ago

no response in over a month from @ayrat555 not sure how to proceed on this?

ayrat555 commented 6 years ago

@raininja I don't see any notable progress there. A lot of commented code, changes in README and json cassette file changes.

raininja commented 6 years ago

OK, so at least I can see that you've looked at the code. That which is commented out is not implemented, as far as I can tell. I've checked with geth, ganache, and parity. . .

hswick commented 6 years ago

Hi @ceresstation I would like to register for this bounty. See #40, but according to gitcoin it doesnt seem like I can right now.

ayrat555 commented 6 years ago

@raininja can you please unassign yourself from this issue on gitcoin? @hswick has done a pretty good job and his PR will be merged soon

raininja commented 6 years ago

OK

On Sat, Oct 6, 2018, 1:00 PM Ayrat Badykov notifications@github.com wrote:

@raininja https://github.com/raininja can you please unassign yourself from this issue on gitcoin? @hswick https://github.com/hswick has done a pretty good job and his PR will be merged soon

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/exthereum/ethereumex/issues/8#issuecomment-427589674, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-iT-TPkF2UOKb-jqPdq6cqfJwT1uCFks5uiOGHgaJpZM4Psv5Q .

ayrat555 commented 6 years ago

@hswick you should try to assign yourself to the issue on gitcoin

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 3 months, 1 week from now. Please review their action plans below:

1) hswick has started work.

Finish up Pull Request- Documentation Handle config more gracefully Include Parity binary

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.4 ETH (89.85 USD @ $224.62/ETH) has been submitted by:

@hswick

@ceresstation please take a look at the submitted work:

(Link Not Provided) by @hswick

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$36,517.60 more funded OSS Work available on the Gitcoin Issue Explorer

ayrat555 commented 6 years ago

@ceresstation ping

hswick commented 6 years ago

@ceresstation pong

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.4 ETH (84.82 USD @ $212.04/ETH) attached to this issue has been approved & issued to @hswick.

Learn more on the Gitcoin Issue Details page
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $47,598.94 more funded OSS Work available on the Gitcoin Issue Explorer

spm32 commented 6 years ago

Sorry about that @hswick, lost track of this in the conference rush, just paid you out!

hswick commented 6 years ago

Thanks @ceresstation appreciate it!

mana-ethereum / ethereumex

Implement Ipc Client #8