search

mandarine3ds / mandarine

A Citra fork with extra options for more performance
GNU General Public License v2.0
475 stars 12 forks source link

video_core: Restore Frame Skip functionality #56

Closed rtiangha closed 4 months ago

rtiangha commented 5 months ago

I noticed you guys were looking at this in the past, so here is a "working" version.

It uses the same algorithm as it did years ago when it was first removed (we're talking Nov 2016) and therefore includes all the same issues. Seems to work better in OpenGL and won't render anything if set too high, but results may vary. Consider it unstable.

I mean seriously, it's super janky and probably won't work with the most popular games unless they were highly compatible with Citra in the first place. But when it does work, it's nice.

I did try to make an Android interface, but I'm not an Android programmer and I don't have a 64-bit device to run it on so I can't test/fix anything that might be wrong. It compiles, but that's all I can verify.

Anyway, do with it what you will.

Gamer64ytb commented 5 months ago

Oh so nice! Does it have any bugs while using frameskip at 1 or 2? I saw a few on Lime

rtiangha commented 5 months ago

Oh so nice! Does it have any bugs while using frameskip at 1 or 2? I saw a few on Lime

It's exactly the same. It's janky; always was but I wasn't around back then to be able to say if it's better or worse now. But figured you guys would like a version that compiled and who knows; maybe you'll be the ones who can fix it. It works for me for the two games I play regularly so I keep it on my personal builds, but I can understand why some wouldn't want to.

Gamer64ytb commented 4 months ago

I merged manually with some improvements due to the inactivity of this PR. Thanks for your work :)

Even if it's buggy, it's a feature, so no reason to leave unmerged