search

mandrewcito / signalrcore

SignalR Core python client
https://mandrewcito.github.io/signalrcore/
MIT License
119 stars 57 forks source link

Reference to undefined function `_send_ping` #34

Closed synapticarbors closed 4 years ago

synapticarbors commented 4 years ago

In perusing the source code for this library I noticed that there is a call to a method of the BaseHubConnection called _send_ping()

https://github.com/mandrewcito/signalrcore/blob/90540f388921a57ddd6a895fadae9527fd745674/signalrcore/hub/base_hub_connection.py#L315

This function is not defined within the source code and as far as I can tell, was never defined (searching through the git history).

I'm guessing it should probably be replaced by something like self.send(PingMessage()). I can open a pull request if this seems reasonable.

mandrewcito commented 4 years ago

Yes,

Of course you can make a pull request. Help is always welcome :D

Thank you!