no https support in 0.8.7?

1337SEnergy commented 4 years ago

from signalrcore.hub_connection_builder import HubConnectionBuilder
import time;

hub = HubConnectionBuilder().with_url("https://socket-v3.bittrex.com/signalr", options={"verify_ssl": False}).with_automatic_reconnect({
"type": "interval",
"keep_alive_interval": 10,
"intervals": [1, 3, 5, 6, 7, 87, 3]
}).build();

def on_open():
    print("open");

def on_close():
    print("close");

hub.on_open(on_open);
hub.on_close(on_close);
hub.start();

while True:
    time.sleep(1);

this should, according to issue #14 work, but it doesn't, I also get the

scheme https is invalid <class 'ValueError'>

websocket-client is 0.54.0

edit: the only reason why I used ws-client 0.54.0 is because it says so in the readme, however signalr core installs ws-client 0.57 by default, as the requirements for it are websocket-client>=0.54.0 for some reason

1337SEnergy commented 4 years ago

0.7.9 does not work either, and this one installs 0.57.0 ws-client as well

mandrewcito commented 4 years ago

As you can see on bittrex docs, their signarl server is an classic signarl server. This library is a client for singlar core. Did you take a look to https://pypi.org/project/signalr-client/?

1337SEnergy commented 4 years ago

sorry, I actually have no idea what signalR actually is, and I also have no idea why bittrex decided to go with this instead of normal WS like every other exchange

I did take a look at signalr-client, but it's not been updated for 4 years, I believe I even tried it, but it wasn't working for some reason as well... maybe I just don't understand this signalR ?

mandrewcito / signalrcore

no https support in 0.8.7? #41