search

mandricigor / imrep

ImReP is a computational method for rapid and accurate profiling of the adaptive immune repertoire from regular RNA-Seq data.
https://mandricigor.github.io/imrep/
28 stars 14 forks source link

bugs of compare.repertories.py #37

Open dormeight opened 5 years ago

dormeight commented 5 years ago

hello, I just ran some RNASeq data with ImRep. Compared with TRUST and mixcr. Thanks to your wonderful work, this program runs really fast! But when I tried to the the compare.repertories.py, I found some bugs. In the function file2dict, after the linereader=csv.reader(file), I guess we still need next(reader) to skip the header line. Also the filenames of outputs of clonality.py don't have samplenames( I ran the script directly in terminal), so it will be unnecessary to add the sample's name when get the filenames from the clonality result folder. I just removed these parts and the script works smoothly. I hope this feedback can be helpful. ^_^

smangul1 commented 5 years ago

Thanks! Would you mind sharing the modified script with us!