manticoresoftware / manticoresearch-buddy

Manticore Buddy is a Manticore Search's sidecar which helps it with various tasks
GNU General Public License v3.0
20 stars 3 forks source link

Queues source wrong boolean fields handling #457

Closed djklim87 closed 3 weeks ago

djklim87 commented 3 weeks ago

Bug Description:

We noticed that boolean fields are being changed to an empty space instead of 0 or false.


REPLACE INTO system.buffer_wiki_source_0 
(id, schema, type, title, title_url, comment, user, server_url, server_name, wiki, meta, namespace, timestamp, bot, minor, length) VALUES 

( 1864940799, '/mediawiki/recentchange/1.0.0', 'categorize', 'Category:Ambassadors of Ireland to Norway', 'https://en.wikipedia.org/wiki/Category:Ambassadors_of_Ireland_to_Norway', '[[:Valentin Iremonger]] added to category, [[Special:WhatLinksHere/Valentin Iremonger|this page is included within other pages]]', 'Asrefaei', 'https://en.wikipedia.org', 'en.wikipedia.org', 'enwiki', '{"uri":"https:\/\/en.wikipedia.org\/wiki\/Category:Ambassadors_of_Ireland_to_Norway","request_id":"9b67f740-0df0-4221-85c4-5f215cafe4d9","id":"8161bbd7-5674-4d12-a1e9-f2f4cd38c9d2","dt":"2025-01-16T07:53:40Z","domain":"en.wikipedia.org","stream":"mediawiki.recentchange","topic":"codfw.mediawiki.recentchange","partition":0,"offset":1399569252}', 14, 1737014020, , 0, '' )

Manticore Search Version:

6.3.8

Operating System Version:

docker

Have you tried the latest development version?

Yes

Internal Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

- [x] Implementation completed - [x] Tests developed - [x] Documentation updated - [x] Documentation reviewed - [x] Changelog updated
djklim87 commented 3 weeks ago

Waiting for review https://github.com/manticoresoftware/manticoresearch-buddy/pull/459

djklim87 commented 3 weeks ago

Deployed in https://github.com/manticoresoftware/manticoresearch/pull/2951

djklim87 commented 3 weeks ago

@PavelShilin89 Update Kafka tests to include checks for boolean fields

PavelShilin89 commented 3 weeks ago

@djklim87 Test updated in PR -https://github.com/manticoresoftware/manticoresearch-buddy/issues/457. Please give feedback or approval for the merger.

PavelShilin89 commented 3 weeks ago

PR - https://github.com/manticoresoftware/manticoresearch/pull/2974 merged into master