mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
211 stars 124 forks source link

Use std::pair instead of QPair in utility files #38396

Closed robertapplin closed 1 week ago

robertapplin commented 2 weeks ago

Description of work

This PR removes the use of QPair for std::pair in the WorkspaceUtils and InterfaceUtils files used in much of the Spectroscopy code.

To test:

Code review and follow these tests https://developer.mantidproject.org/Testing/Inelastic/DataProcessorTests.html

Reviewer

Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

Functional Tests

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.