mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
211 stars 124 forks source link

Move from matplotlib 3.8 to 3.9 #38435

Closed peterfpeterson closed 2 days ago

peterfpeterson commented 1 week ago

With the move to numpy v2 in #38420, we can move to the latest stable of release of matplotlib. According to the matplotlib 3.9 notes on runtime dependencies, qt5 is still supported. Let's see what happens.

Link to changes in matplotlib 3.9

There is no associated issue but this is associated with EWM8431

To test:

Probably should do some quick testing of things that rely on matplotlib like SliceViewer, otherwise if the tests pass it should be good to go.


Reviewer

Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

Functional Tests

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

github-actions[bot] commented 1 week ago

:wave: Hi, @peterfpeterson,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.