search

manu354 / cryptocurrency-arbitrage

A cryptocurrency arbitrage opportunity calculator. Over 800 currencies and 50 markets.
GNU General Public License v3.0
1.19k stars 336 forks source link

added kraken api, and removed it from cryptowatch #10

Closed Primly closed 7 years ago

Primly commented 7 years ago

Unfortunately kraken doesn't really provide an overall market summery with price info as many other APIs do. This makes it necessary to include all the desired coinpairs in the URL. The "safest" way to do this would probably be to have a function in the kraken markets object that gets all the kraken asset pairs from the API, parses them out of the JSON, and then adds them to a URL and returns that. But that seems like a lot of code to write, and would only have the advantage of never having to worry about adding a coin pair manually when kraken adds one to the exchange - which may happen, maybe once or twice a year, tops?

manu354 commented 7 years ago

Thanks that's a good way of doing it. Again thanks for helping out :)

Primly commented 7 years ago

No prob man, super excited for this project. I just started in Node about 6 months ago, around the same time I started getting into cryptos - so this is exactly what i've been looking for!