manuelroemer / Nullable

A source code only package which allows you to use .NET's nullable attributes in older target frameworks like .NET Standard 2.0 or the "old" .NET Framework.
https://www.nuget.org/packages/Nullable
MIT License
186 stars 8 forks source link

Support .NET Compact Framework 3.5 #3

Closed skarllot closed 5 years ago

skarllot commented 5 years ago

The Nullable package can support Compact Framework without any downsides.

manuelroemer commented 5 years ago

Hi, thank you for your interest in adding a new target!

I have two questions about the changes:

  1. Is the net35-cf target framework moniker official (or at least "semi-official"), i.e. do other projects use it? I couldn't find much information online about this.
  2. Have you tested the changes by building the NuGet package (see build.ps1), creating a local NuGet feed and checking if the package installs correctly into a .NET Compact project?
    >> I must make sure that this change installs correctly and I do not have any .NET Compact Framework setup on my machine right now.

If these two questions are answered, I am happy to integrate these changes.