search

mapaction / mapaction-toolbox

A collection of tools to help streamline the process of producing maps including data renaming and map exports.
GNU General Public License v3.0
3 stars 1 forks source link

ESRI dlls included in build assets #161

Open andrewphilipsmith opened 5 years ago

andrewphilipsmith commented 5 years ago

Expected Behavior

Only MapAction created assets should be included in the build assets. This includes the files embeded in the .esriAddin file (which is itself a zipfile with a changed extension).

Actual Behavior

Various ESRI dlls are included in the build. These are also embended into the .esriAddin file making it unnecessarily large. This prevents us from distributing the binary build publically as it would be a violation of ESRI licence agreement. Distributing the source code is OK.

Steps to Reproduce the Problem

  1. Build the project based on this commit: https://github.com/mapaction/mapaction-toolbox/commit/07942f2ed47f8a8df5122d04b45010c05c041847

Specifications

clairebyrne commented 4 years ago

@andrewphilipsmith @shurst-ma this one can be closed?

andrewphilipsmith commented 4 years ago

@clairebyrne Still a bug in the latest stable release and test builds.