search

mapaction / mapaction-toolbox

A collection of tools to help streamline the process of producing maps including data renaming and map exports.
GNU General Public License v3.0
3 stars 1 forks source link

Export path should be zero-padded to match that done by MapChef #194

Closed harry-gibson closed 3 years ago

harry-gibson commented 4 years ago

MapChef generates version number subfolders that are zero-padded e.g. v01. We should do the same, currently we do v1 (but the filename is taken from the MXD filename and so matches the map-chef generated one).

https://github.com/mapaction/mapaction-toolbox/blob/6ac15fc0dfeeb70753a4f6b318373f57c8a1a14f/arcgis10_mapping_tools/MapActionToolbars/frmExportMain.cs#L524

harry-gibson commented 3 years ago

Done, also changing to use lowercase 'v' throughout.

Have also changed the version number as specified in the utm tag of the QR code URL to be zero-padded too i.e. change from https://maps.mapaction.org/dataset/djibouti-2019-12-ma001?utm_source=qr_code&utm_medium=mapsheet&utm_campaign=djibouti-2019-12&utm_content=ma001-v1 to https://maps.mapaction.org/dataset/djibouti-2019-12-ma001?utm_source=qr_code&utm_medium=mapsheet&utm_campaign=djibouti-2019-12&utm_content=ma001-v01

@andrewphilipsmith please can you advise if this change to the URL is ok or if that needs to be kept in the old form? As it's only in the UTM tag it appears to make no difference to what page is seen by the user following the URL anyway.

harry-gibson commented 3 years ago

The map no element on the templates needs enlarging slightly to fit a two-digit map number and two-digit version - which all versions now will be if we are to display them zero-padded as well. To agree on before merging this.